fix: Save workflow error when updating with parameters#961
Merged
amanda11 merged 3 commits intoMar 14, 2022
Conversation
Contributor
|
This looks great to me, just needs a rebase to pick up latest from master. I would like to give the changes a try before approval- hope to take it for spin later in week (unless someone else gets to review earlier than that). |
amanda11
approved these changes
Mar 10, 2022
amanda11
left a comment
amanda11
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution, this looks great and fixed the original issue I raised.
Could you please do a rebase, and then we should be able to merge this in for the next release.
Many thanks,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 862
Saving a workflow immediately after creating and running it causes a 400 HTTP response code for a bad request. There is an extra property in the PUT request body that is not supported by the API. Finer details and replication steps can be found within the issue. These changes removes the
_nameproperty from the request body, resulting in a successful "save".This also fixes some react errors regarding
ref; it cannot be used for function components, and the_detailsvariable is not defined either.React Error Example (when loading multiple pages):
