Add link to trigger on History page#950
Merged
Merged
Conversation
cognifloyd
reviewed
Jan 2, 2022
cognifloyd
left a comment
cognifloyd
left a comment
Member
There was a problem hiding this comment.
I love the idea of lining to the trigger. I don't know all the JavaScript bits in st2web to decide if this is correct.
Could you add some before and after screenshots to highlight where this link will be added?
Contributor
Author
|
Before After. Note This is where it links to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the History page, there is a TRIGGER DETAILS section on the lower right.
The Trigger name is displayed but it would be better it linked to the actual Trigger page.
This PR turns the Trigger name into a link.