Skip to content

Rerun action new enhancements#949

Merged
m4dcoder merged 21 commits into
StackStorm:masterfrom
pradnya-orchestral:Rerun_action_new_enhancements
Mar 7, 2022
Merged

Rerun action new enhancements#949
m4dcoder merged 21 commits into
StackStorm:masterfrom
pradnya-orchestral:Rerun_action_new_enhancements

Conversation

@pradnya-orchestral

Copy link
Copy Markdown
Contributor

While rerunning action now fields with default value will be shown in black colour not in gray colour and after removing value from fields having default value, it will not show default value for that field, user has to enter some value there.
As default value will be not automatically filled so we have to make those fields compulsory otherwise submit will not perform successfully.

@m4dcoder m4dcoder added this to the 3.7.0 milestone Jan 4, 2022

@m4dcoder m4dcoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral If the action has a parameter with default value and I changed the default value to something else in my previous run, then on a rerun, the parameter doesn't show the changed value.

@m4dcoder m4dcoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral Can you review the "Files changed" and make sure unnecessary changes like line deletion, extra line, extra space are reverted? Thanks.

return (
<div className="st2-rerun">
<Popup title="Rerun an execution" onCancel={onCancel} data-test="rerun_popup">
<h4 style={{ padding:'20px 20px 0' }}>The input values from the previous run are applied by default and displayed in black. The original default values of the action parameters are displayed in grey.</h4>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral Can you make this normal text, larger text but not bold and closer to the title? Thanks

@m4dcoder m4dcoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradnya-orchestral Something has changed and when I clicked rerun, it fills the entire screen on chrome.

@m4dcoder

m4dcoder commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

@pradnya-orchestral Thanks for your diligence to explain that the current rerun is full screen. For some reason, I have an impression that it's not full screen before. I changed the text size of the description from 24px to 20px so it's not the same size as the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants