You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we cannot simply remove the old v6 icons the changes create an alias for that package (@stackoverflow/stacks-icons-legacy). The main reason this PR is touching many files is because the docs and the stacks svelte components still utilize the old icons for now.
We will gradually migrate to the new icons as we work on components and updating the stacks docs.
Ultimately the goal would be to remove every reference of the legacy icon package and uninstall it.
The only places where we can see the new icons are the following as of now:
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
The reason will be displayed to describe this comment to others. Learn more.
I looked through the changes and they all seem reasonable. I also ran this locally to see the docs changes and I think they are good. I appreciate the compromise going with a legacy package with the plan to remove it when the time comes. Thanks @giamir
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPARK-101
This PR integrates the new beta stacks icons (and spots) in the monorepo.
Since we cannot simply remove the old v6 icons the changes create an alias for that package (
@stackoverflow/stacks-icons-legacy). The main reason this PR is touching many files is because the docs and the stacks svelte components still utilize the old icons for now.We will gradually migrate to the new icons as we work on components and updating the stacks docs.
Ultimately the goal would be to remove every reference of the legacy icon package and uninstall it.
The only places where we can see the new icons are the following as of now: