feat(avatar): update to new visual language #2019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e72459 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
giamir
force-pushed
the
SPARK-61/avatar
branch
from
7ba3959 to
fcd0204
Compare
dancormier
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
I keep going back and forth on the size of the indicator on the 24px avatar variant 😂. I think that means it's fine! Thanks for the thoughtfulness towards this component @giamir
LGTM (once activity indicator is merged and we make sure it plays nicely with this)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-61
Figma
Here is what changed:
.s-avatar--indicatorclass for positioning an activity indicator element in relation to the avatar. (docs)statusprop. When set toonlineit will show an activity indicator on the avatar. (storybook)Note: This PR should be merged after the activity indicator one get merged.