- 
                Notifications
    You must be signed in to change notification settings 
- Fork 99
chore(colors): update color palettes #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 93a97e4.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| 🦋 Changeset detectedLatest commit: 137a3f0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| ✅ Deploy Preview for stacks ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| ✅ Deploy Preview for stacks-svelte ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CGuindon, @leileitun3 I've popped in a few questions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to reviewers: This file is where the vast majority of changes have happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color values should be (I think some of these are the ones Lei Lei tweaked recently):
- Light mode blue400: hsl(226, 67%, 95%)
- Light mode green200: hsv(82, 30%, 95%)
- HC Light mode green300: hsv(82, 80%, 63%)
- HC Light mode green400: hsv(82, 93%, 38%)
- Dark mode red500: hsv(0, 20%, 99%)
- Light mode yellow200: hsv(48, 36%, 96%);
- Light mode pink
 100: hsv(293, 6%, 99%);
 200: hsv(293, 25%, 95%);
 300: hsv(293, 45%, 95%);
 400: hsv(293, 68%, 91%);
 500: hsv(293, 80%, 70%);
 600: hsv(293, 90%, 45%);
- HC Light mode pink300: hsv(293, 68%, 91%);
- HC Dark mode pink400: hsv(293, 30%, 80%);
| @CGuindon thank you for the detailed suggestions. You saved me a lot of time (your bolding helped a lot!) 🫶 I've made those changes in 6a9f965. I've also: 
 
 I might be misunderstanding. You're suggesting that the dark and dark HC orange palettes are swapped? To me it looks correct. Can you clarify @CGuindon?   | 
| 
 @dancormier The oranges looked swapped in the preview but I don't think I saw anything that off in the code file you sent me... Would that preview need to be regenerated? | 
| @dancormier I don't mind having the buttons remain blue in the Teams template/default but ideally SE sites (without custom) use the new black buttons down the line. | 




SPARK-49
Deploy preview
This PR updates Stacks to use the new SHINE color palettes.
TODO
(verify) Update or remove translucent color sets (these are mostly used for focus rings)cc @leileitun3