Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
============================================
- Coverage 62.71% 59.11% -3.61%
+ Complexity 804 780 -24
============================================
Files 113 114 +1
Lines 3782 3798 +16
Branches 512 508 -4
============================================
- Hits 2372 2245 -127
- Misses 1196 1352 +156
+ Partials 214 201 -13 🚀 New features to boost your workflow:
|
armiol
requested changes
Jun 25, 2025
contexts/grpc-context/src/main/java/io/spine/logging/context/grpc/GrpcContextDataProvider.java
Outdated
Show resolved
Hide resolved
flogger/middleware/src/main/java/io/spine/logging/flogger/backend/Platform.java
Outdated
Show resolved
Hide resolved
Contributor
|
@alexander-yevsyukov also, IDEA inspections tell me that in |
Contributor
Author
This is so because it is a KMP module. It does not have Java code at all. |
armiol
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the dependencies via pulling the latest
config. Annotations were migrated to JSpecify.Project structure changes
Platformclass no longer depend onio.spine.logging.LevelAPI thus avoiding the circular dependency between the:loggingand the:middlewaremodules which was possible for a KMP in previous versions of Gradle and Kotlin Gradle plugins..flogger.was updated to mention both Flogger Authors and TeamDev.getThreadID()in favor ofgetLongThreadID().