Migrate remaining code to Kotlin#133
Merged
alexander-yevsyukov merged 33 commits intomasterfrom Sep 16, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 14.82% 14.37% -0.46%
+ Complexity 147 120 -27
============================================
Files 102 102
Lines 2691 2658 -33
Branches 374 377 +3
============================================
- Hits 399 382 -17
+ Misses 2262 2245 -17
- Partials 30 31 +1 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR completes the migration of remaining Java production code to Kotlin, focusing primarily on logging backend and platform implementations. The changes also include a version bump from 2.0.0-SNAPSHOT.400 to 2.0.0-SNAPSHOT.410.
- Migrated Java logging backend implementations to Kotlin
- Migrated platform system components from Java to Kotlin
- Updated version numbers across build files and dependencies
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Version bump to 2.0.0-SNAPSHOT.410 |
| pom.xml | Version bump to 2.0.0-SNAPSHOT.410 |
| platforms/jvm-default-platform/src/test/kotlin/io/spine/logging/backend/system/DefaultPlatformSpec.kt | Updated method names from getXxxImpl to doGetXxxImpl for test methods |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt | Migrated from Java to Kotlin |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/StackBasedCallerFinder.kt | Migrated from Java to Kotlin |
| platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt | Migrated from Java to Kotlin |
| contexts/grpc-context/src/main/kotlin/... | Migrated grPC context classes from Java to Kotlin |
| backends/log4j2-backend/src/main/kotlin/... | Migrated Log4j2 backend classes from Java to Kotlin |
| backends/jul-backend/src/main/kotlin/... | Migrated JUL backend classes from Java to Kotlin |
| dependencies.md | Updated timestamps and version references |
Files not reviewed (1)
- .idea/inspectionProfiles/Project_Default.xml: Language not supported
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt
Show resolved
Hide resolved
...m-default-platform/src/main/kotlin/io/spine/logging/backend/system/StackBasedCallerFinder.kt
Show resolved
Hide resolved
...orms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # dependencies.md
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt
Outdated
Show resolved
Hide resolved
backends/log4j2-backend/src/test/kotlin/io/spine/logging/backend/log4j2/ValueQueueSpec.kt
Show resolved
Hide resolved
contexts/grpc-context/src/main/kotlin/io/spine/logging/context/grpc/GrpcContextDataProvider.kt
Show resolved
Hide resolved
...orms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt
Show resolved
Hide resolved
armiol
requested changes
Sep 16, 2025
Contributor
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM except for a tiny request.
backends/jul-backend/src/main/kotlin/io/spine/logging/backend/jul/AbstractJulBackend.kt
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates remaining production code from Java to Kotlin.
Other notable changes
flogger.now use the prefixspine.logging..