Restore and deprecate TypeOptionDiscovered#348
Merged
yevhenii-nadtochii merged 4 commits intomasterfrom Apr 15, 2025
Merged
Conversation
Contributor
Author
armiol
approved these changes
Apr 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=========================================
Coverage 74.82% 74.82%
Complexity 615 615
=========================================
Files 196 196
Lines 4254 4254
Branches 396 396
=========================================
Hits 3183 3183
Misses 938 938
Partials 133 133 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the binary compatibility with the older ProtoData from
mc-java. Invalidation, it brings the descriptors for the removed type, but without the Java type itself.TypeOptionDiscoveredis restored asdeprecated.