Fill in the span property of OneofGroup#346
Merged
yevhenii-nadtochii merged 10 commits intomasterfrom Apr 14, 2025
Merged
Conversation
added 8 commits
April 7, 2025 14:08
yevhenii-nadtochii
changed the title
span property of OneOfGroupspan property of OneOfGroup
yevhenii-nadtochii
changed the title
span property of OneOfGroupspan property of OneofGroup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
============================================
- Coverage 74.87% 74.81% -0.07%
Complexity 615 615
============================================
Files 196 196
Lines 4259 4256 -3
Branches 394 396 +2
============================================
- Hits 3189 3184 -5
- Misses 937 939 +2
Partials 133 133 🚀 New features to boost your workflow:
|
Contributor
Author
armiol
approved these changes
Apr 14, 2025
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@yevhenii-nadtochii LGTM in general. See my comment though.
| val className = javaClassName(header) | ||
|
|
||
| /** | ||
| * Finds a fully qualified Java class name, generated for the Protobuf type with this name. |
Collaborator
There was a problem hiding this comment.
I am not sure why we would say "fully qualified" here. I would remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-uses the
OneofDescriptor.toOneOfGroup()method to createOneofGroupinstance. Created this way, theOneofGroup.spanfield will be correctly populated. Thus, emitted compilation errors will point to the correct file and position.Other changes are the following:
OneofGroup.qualifiedNameextension, as we have forField.TypeName.findJavaClassName()counterpart that returns a nullable result instead of throwing.core-javato pick up the latest changes inspine-time.