feat: Add ingestion support for AZContributor on MGMT Groups, RGs, and Subscriptions - BED-5023#2478
feat: Add ingestion support for AZContributor on MGMT Groups, RGs, and Subscriptions - BED-5023#2478StranDutton wants to merge 1 commit intomainfrom
Conversation
… Groups, Resource Groups, and Subscriptions
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Literally ALL jobs are failing right now but that is to be expected because the new types are dependent on the next AzureHound release which isn't out yet obviously. I'm just preemptively making the changes here as a proof of concept and will come back and polish and fix things when I make progress on AzureHound 🫡 🤠 |
Motivation and Context
Resolves BED-5023
Why is this change required? What problem does it solve?
AzureHound is being updated to collect
AZContributorrole assignments for Management Groups, Resource Groups, and Subscriptions (emitting new Kind values:AZManagementGroupContributor,AZResourceGroupContributor,AZSubscriptionContributor) in this PR. However, BHCE's ingestion pipeline had no mapping for these Kinds. ThegetKindConverterfalls through to the default case when it encounters these new Kinds, which just drops the data. This PR adds the missing ingestion logic so these relationships are created in the graph.Please see this writeup (on Notion) for more context about the problem.
How Has This Been Tested?
Unit tests are TBD - waiting to work more on this until I get more eyes on this.
See this PR for full testing notes (which are currently TBA).
Screenshots (optional): TBD
Types of changes
Checklist: