Skip to content

feat: Removed redraw of graph on entity panel click - BED-7543#2469

Open
specter-flq wants to merge 1 commit intomainfrom
BED-7543--dis-exp-accordion-redraw
Open

feat: Removed redraw of graph on entity panel click - BED-7543#2469
specter-flq wants to merge 1 commit intomainfrom
BED-7543--dis-exp-accordion-redraw

Conversation

@specter-flq
Copy link
Contributor

@specter-flq specter-flq commented Mar 5, 2026

Description

Removed a block of code that would set the necessary params in the url to re render the graph. I didn't remove the relationship query functionality from the url because we spoke the possibility of bring it back as an optional rendering in the near future.

Motivation and Context

Resolves: BED-7543

How Has This Been Tested?

Manually validated and existing tests pass

Screenshots (optional):

EntityPanel.mp4

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced expanded panel functionality to consistently load relationship data. Removed unnecessary query restrictions that could prevent proper execution of data relationships. Users now experience more reliable and predictable behavior when expanding panels to view related information across all use cases.

@specter-flq specter-flq self-assigned this Mar 5, 2026
@specter-flq specter-flq added the user interface A pull request containing changes affecting the UI code. label Mar 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

Removed render-limit-based conditional logic from the EntityInfoDataTableGraphed component. The component no longer checks if data is under a render limit before setting expanded panel section parameters, simplifying the query parameter construction flow.

Changes

Cohort / File(s) Summary
Render Limit Logic Removal
packages/javascript/bh-shared-ui/src/components/EntityInfoDataTableGraphed/EntityInfoDataTableGraphed.tsx
Removed NODE_GRAPH_RENDER_LIMIT import, isUnderRenderLimit calculation, and conditional inclusion of relationship query params (searchType, relationshipQueryType, relationshipQueryItemId) in expandedPanelSectionsParams. Expanded panel params now set expandedPanelSections unconditionally without relationship query fields injection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing graph redraw logic on entity panel click, with the associated ticket reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description covers the template requirements with clear sections for Description, Motivation and Context (with ticket reference), testing approach, and type of change classification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BED-7543--dis-exp-accordion-redraw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user interface A pull request containing changes affecting the UI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants