fix(audit): add missing client deletion audit logs - BED-7516

[cami-specter]

Description

TODO:
See info in BHE PR: https://github.com/SpecterOps/bloodhound-enterprise/pull/1068

Motivation and Context

Resolves BED-7516

Adds audit logs for client deletion.

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Database Migrations

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README #672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

Release Notes

• Chores
  • Enhanced system audit logging to record client deletion events, improving traceability of deletion actions and supporting better operational visibility and compliance reporting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8ab9bf and cb8c31e.

📒 Files selected for processing (1)

• cmd/api/src/model/audit.go

🚧 Files skipped from review as they are similar to previous changes (1)

• cmd/api/src/model/audit.go

---

📝 Walkthrough

Walkthrough

Added a new exported audit action constant AuditLogActionDeleteClient with value "DeleteClient" to the AuditLogAction const block in cmd/api/src/model/audit.go.

Changes

Cohort / File(s)	Summary
Audit Model cmd/api/src/model/audit.go	Added new exported constant AuditLogActionDeleteClient AuditLogAction = "DeleteClient" to the AuditLogAction const block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• BED-5767 fix audit log broken and missing #1490 — Adds similar AuditLogAction constants to the same audit model file.

Suggested reviewers

• irshadaj
• cweidenkeller

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description includes the required Motivation and Context section with ticket reference, but lacks detailed testing information and leaves documentation status unclear.	Complete the 'How Has This Been Tested?' section with specific testing details and verify whether documentation updates (API docs, code comments) were completed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a missing audit log constant for client deletion, with the associated Jira ticket reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch wip-BED-7516-add-audit-logs-dc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}