Skip to content

Changes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumarharshvardhann wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions SUBMISSION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
## Submissions

Use this md to tell us the bugs you solved and also explain the approach you had while solving them. Make them bulleted like
Following are the changes made:

1. Accessibility - **Something here**
2. Aesthetics - **Something here**
3. Testing - **Something here**
4. Technicality Improvements - **Something here**
1. Aesthetics -
a. Hamburger Icon added for menu icon link
b. Slider menu Color changed
c. Slider menu, header sizes adjusted
d. Header style changed
e. Feed list center-aligned
2. Technicality Improvements -
a. The Slider Menu slides back in and out on clicking on the hamburger icon
13 changes: 13 additions & 0 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,17 @@ $(function () {
/* When the menu icon is clicked on, we need to toggle a class
* on the body to perform the hiding/showing of our menu.
*/

$(document).ready(function(){
$("a.menu-icon-link").click(function(){
$(".slide-menu").toggleClass('menu-hidden');
});
/*on scroll slide menu back in*/
$(".feed").scroll(function(){
$(".slide-menu").addClass("menu-hidden");
});
});



}());
45 changes: 24 additions & 21 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@
<link rel="stylesheet" href="icomoon.css">
<link rel="stylesheet" href="style.css" content-type="text/css">
<!--Only for testing <link href="https://unpkg.com/[email protected]/mocha.css" rel="stylesheet" /> -->

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.7.2/css/all.css" integrity="sha384-fnmOCqbTlWIlj8LyTjo7mOUStjsKC4pOpQbqyi7RrhN7udi9RwhKkMHpvLbHG9Sr" crossorigin="anonymous">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/bulma/0.7.4/css/bulma.min.css">
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Courgette">
</head>
<body class="menu-hidden">
<div id='mocha'></div>
<div class="header">
<a href="#" class="menu-icon-link">
<i class="icon-list"></i>
<i class="icon-list fas fa-bars" ></i>
</a>
<div class="text-center">
<h1 class="header-title" aria-describedby="The heading of the present feed">Feeds</h1>
Expand All @@ -29,70 +32,70 @@ <h1 class="header-title" aria-describedby="The heading of the present feed">Feed
<a class="entry-link" href="https://css-tricks.com/the-magic-of-react-based-multi-step-forms/">
<article class="entry">
<h2>The Magic of React-Based Multi-Step Forms</h2>
<p>Nathan Sebhastian</p>
<p>Nathan Sebhastian</p>
</article>
</a>

<a class="entry-link" href="https://medium.com/@sachagreif/announcing-the-state-of-css-2019-survey-e1e4268df64d">
<article class="entry">
<h2>The #StateOfCSS 2019 Survey</h2>
<p>Geoff Graham</p>
<p>Geoff Graham</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/getting-to-grips-with-the-airtable-api/">
<article class="entry">
<h2>Getting to Grips with the Airtable API</h2>
<p>Robin Rendle</p>
<p>Robin Rendle</p>
</article>
</a>

<a class="entry-link" href="https://synd.co/2GemPNV">
<article class="entry">
<h2>Use monday.com to manage and share projects all in one place</h2>
<p>Geoff Graham</p>
<p>Geoff Graham</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/the-smart-ways-to-correct-mistakes-in-git/">
<article class="entry">
<h2>The Smart Ways to Correct Mistakes in Git</h2>
<p>Tobias Günther</p>
<p>Tobias Günther</p>
</article>
</a>

<a class="entry-link" href="https://cloudinary.com/blog/a_chaotic_good_guide_to_image_performance_part_1">
<article class="entry">
<h2>“the closest thing web standards have to a golden rule”</h2>
<p>Chris Coyier</p>
<p>Chris Coyier</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/%e2%80%8b%e2%80%8bavoiding-those-dang-cannot-read-property-of-undefined-errors/">
<article class="entry">
<h2>​​Avoiding those dang cannot read property of undefined errors</h2>
<p>Adam Giese</p>
<p>Adam Giese</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/a-site-for-front-end-development-conferences-built-with-11ty-on-netlify/">
<article class="entry">
<h2>A Site for Front-End Development Conferences (Built with 11ty on Netlify)</h2>
<p>Chris Coyier</p>
<p>Chris Coyier</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/quick-whats-the-difference-between-flexbox-and-grid/">
<article class="entry">
<h2>Quick! What’s the Difference Between Flexbox and Grid?</h2>
<p>Chris Coyier</p>
<p>Chris Coyier</p>
</article>
</a>

<a class="entry-link" href="https://css-tricks.com/a-funny-thing-happened-on-the-way-to-the-javascript/">
<article class="entry">
<h2>A Funny Thing Happened on the Way to the JavaScript</h2>
<p>Jason Rodriguez</p>
<p>Jason Rodriguez</p>
</article>
</a>
</div>
Expand Down
42 changes: 32 additions & 10 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,25 +43,39 @@ h2 {
color: #fff;
position: fixed;
top: 0;
height: 4em;
width: 100%;
padding: 0.5em 1em;
/* padding: 0.5em 0.5em; */
}

.header-title {
background-color: #2998c4;
border-radius: 50vw;
padding: 0.25vw 1vw 0.25vw 1vw;
font-family: 'Courgette';
font-size: 1em;
width: 50vw;
}

a.menu-icon-link {
margin-top: 10vw;
}

.icon-list {
font-size: 1.5em;
font-size: 1em;
color: #FFF;
}

.slide-menu {
position: absolute;
top: 3.5em;
top: 4em;
padding: 1em;
background: #0984b4;
background-color: #262626;
height: 100%;
width: 10em;
transform: translate3d(0, 0, 0);
transition: transform 0.2s;
}
transition: transform 1s;
}

.slide-menu ul {
list-style: none;
Expand All @@ -82,17 +96,25 @@ h2 {
padding: 0.5em 0;
}

.menu-hidden .slide-menu {
.menu-hidden {
transform: translate3d(-12em, 0, 0);
transition: transform 0.2s;
transition: transform 1s;
}

/*.menu-appear {
transform: translate3d(12em, 0, 0);
transition: transform 3s;
}*/

.feed {
margin: 4em 0 0;
margin: 4em 4em 4em 35vw;
text-align: left;
width: 100vw;
}

.entry {
border-bottom: 1px solid #ddd;

padding: 1em;
margin: 0.5em 0;
/* margin: 0.5em 0; */
}