avoid calling messageUIDelegate.loaded repeatedly#650
Conversation
If the rendering app dispatches the event `sp.showMessage` multiple times and the consentUI is being presented, clients' app can crash if their code is not guarding against re-presenting the consent ViewController
|
@andresilveirah Thanks again for merging and crediting #649! 😊 One small concern with the guard: There's also a minor issue in the test: Happy to be wrong if I'm missing something though! |
|
Hey @sampaioroberto you are absolutely right about both, the test and the racing condition when calling |
|
Hey @andresilveirah Glad it helped! Are you planning to open a new PR with the flag approach, or would you like me to reopen #649? |
If the rendering app dispatches the event
sp.showMessagemultiple times and the consentUI is being presented, clients' app can crash if their code is not guarding against re-presenting the consent ViewController.Almost entirely inspired on #649