DIA-5947 implement dismissMessage#867
Merged
Merged
Conversation
Nevazhnovu
reviewed
Jul 18, 2025
| fun dismissMessage() | ||
|
|
||
| @Deprecated(message = "This method is deprecated and has no effect.") | ||
| fun dispose() |
Contributor
There was a problem hiding this comment.
@andresilveirah why don't we remove it altogether?
Member
Author
There was a problem hiding this comment.
I think it's less intrusive if we simply trigger a dismiss action. The SDK will call onSPUIFinished and the app should already be prepared to remove the view on that callback. But if we get feedback it's better to remove the view all together, we can do that too.
| action = SPConsentAction( | ||
| actionType = MSG_CANCEL, | ||
| campaignType = campaignType, | ||
| messageId = "" |
Member
Author
There was a problem hiding this comment.
Not a typo. We don't have that information easily available. Since the dismiss doesn't make any network request, it's okay to set it as empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.