feat(frontend): Implement Multi-Signature Task Registration Flow (#400) - #525
Merged
Merged
Conversation
|
@Gezziy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Pr under review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #400
Summary of Changes
Domain Layer: Added frontend/app/lib/multisig.ts containing pure typescript helpers for proposal verification, signer validations (Stellar key patterns G... and contract IDs C...), immutable approval accumulation, and localStorage storage management under key 'sorotask:multisig_proposals'.
State & Hook Layer: Created frontend/app/hooks/useMultiSigRegistration.ts managing the lifecycle transitions (pending_approvals ➡️ ready ➡️ executing ➡️ executed | failed) and executing on-chain transactions via the SorobanService.executeContractCall interface.
UI Layer: Designed frontend/app/components/MultiSigTaskRegistration.tsx, a three-phase (Propose ➡️ Approve ➡️ Execute) tabbed interface containing a co-signer list, validation error alerts, progress meters, and transaction status indicators (linking out to Stellar Expert Futurenet).
Test Suite: Authored frontend/app/tests/MultiSigTaskRegistration.test.tsx containing 27 scenarios covering validation, edge-case persistence limits, mock ledger transaction successes/failures, achieving 99.91% statements and 88.23% branches coverage.
Dependencies: Added @stellar/freighter-api@^6.0.1 and @stellar/stellar-sdk@^15.1.0 to frontend dependencies.
Reason for Changes
Enables decentralized team governance of task registrations in SoroTask. Users can propose registrations, gather co-signer approval thresholds client-side using secure Freighter wallet integration, and execute registrations on the Stellar/Soroban Futurenet blockchain.
Reviewer Notes