Repository navigation
Update and rename schema-registry-beta.md to schema-registry.md - #364
Conversation
|
Please mark whether you used Copilot to assist coding in this PR
|
There was a problem hiding this comment.
✨ PR Review
The PR successfully updates the schema registry documentation from beta to GA version with comprehensive changes to support Solace Schema Registry. However, there are several placeholder content and formatting issues that need to be addressed before publication.
3 issues detected:
🎯 Scope - Placeholder text and incomplete content remains in production documentation
Details: The documentation contains unfinished placeholder content that will confuse users. There are "TBD" video references and "Insert image" placeholders that need to be completed before publication.
File:markdown/schema-registry-beta/schema-registry.md🧾 Readability - Mixed usage of "SERDES" and "SERDEs" creates terminology inconsistency
Details: The document uses both "SERDES" and "SERDEs" inconsistently throughout the content, which may confuse readers about the correct terminology.
File:markdown/schema-registry-beta/schema-registry.md🧾 Readability - Non-standard markdown syntax may not render properly
Details: The note formatting uses [!NOTE] syntax which is not standard markdown and may not render correctly in all markdown processors.
File:markdown/schema-registry-beta/schema-registry.md
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
Chaymee
left a comment
There was a problem hiding this comment.
Found a few things that we need to address before approval
| ```json | ||
| { | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "title": "ClockInOut", |
There was a problem hiding this comment.
title needs to be clock-in-out to match the JCSMP sample
There was a problem hiding this comment.
✨ PR Review
The PR successfully updates the documentation from Apicurio Registry to Solace Schema Registry with comprehensive changes including deployment methods and code examples. However, there are some technical inaccuracies and incomplete content that need attention.
2 issues detected:
🐞 Bug - Documentation states "Avro schema" but the actual content is a JSON schema format.
Details: The documentation incorrectly references "Avro schema" when describing JSON schema content. This mismatch between the description and actual schema format will confuse users about what type of schema they are working with.
File:markdown/schema-registry-beta/schema-registry.md (177-177)🐞 Bug - Windows command has malformed syntax with duplicate patterns and incorrect variable references.
Details: The Windows command syntax for loading Docker images contains syntax errors with duplicate patterns and incorrect escaping that will cause execution failures.
File:markdown/schema-registry-beta/schema-registry.md (94-94)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
There was a problem hiding this comment.
✨ PR Review
The PR significantly updates the schema registry documentation by renaming it from beta to GA and updating content to focus on Solace Schema Registry instead of Apicurio Registry. However, several placeholder content and syntax issues remain that need to be addressed.
3 issues detected:
🧾 Readability - Placeholder text "Insert image" remains in the documentation making it appear unfinished.
Details: The documentation still contains unfinished placeholder content with "Insert image" that will confuse users and indicates incomplete documentation.
File:markdown/schema-registry-beta/schema-registry.md (144-144)🐞 Bug - The command contains duplicate *.tar.gz patterns and incorrect spacing that will prevent proper execution.
Details: The Windows command for loading Docker images has syntax errors with duplicate file patterns that will cause execution failures.
File:markdown/schema-registry-beta/schema-registry.md (94-94)🧾 Readability - Non-standard [!NOTE] syntax may not render properly across different markdown processors.
Details: The document uses [!NOTE] syntax which is not standard markdown and may not render correctly in all markdown processors.
File:markdown/schema-registry-beta/schema-registry.md (315-315)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
|
|
||
|
|
||
| 2. Open a terminal or command prompt window and navigate to the extracted location of the folder called ```solace-schema-registry-dist```. | ||
| 3. Run the command ```for img in {docker-images}/*.tar.gz; do docker load -i "$img"; done``` to load docker images. For Window use this instead ```for %i in (docker-images\*.tar.gz \*.tar.gz) do docker load -i "%i"```. |
There was a problem hiding this comment.
🐞 Bug - Windows Command Syntax: Fix the Windows command to use correct syntax: for %i in (docker-images\*.tar.gz) do docker load -i "%i"
| 3. Run the command ```for img in {docker-images}/*.tar.gz; do docker load -i "$img"; done``` to load docker images. For Window use this instead ```for %i in (docker-images\*.tar.gz \*.tar.gz) do docker load -i "%i"```. | |
| 3. Run the command ```for img in {docker-images}/*.tar.gz; do docker load -i "$img"; done``` to load docker images. For Window use this instead ```for %i in (docker-images\*.tar.gz) do docker load -i "%i"```. |
There was a problem hiding this comment.
✨ PR Review
The PR successfully transitions from the beta Apicurio Registry documentation to the GA Solace Schema Registry version with comprehensive updates. However, several technical issues from the previous version persist and need attention.
3 issues detected:
🐞 Bug - Duplicate file patterns in Windows batch command syntax will prevent proper execution.
Details: The Windows command for loading Docker images contains duplicate file patterns that will cause execution failures when users attempt to run the command.
File:markdown/schema-registry-beta/schema-registry.md (94-94)🧾 Readability - Placeholder content in published documentation creates confusion and indicates incomplete preparation.
Details: The documentation contains an "Insert image" placeholder that indicates incomplete content and will confuse users who expect a complete walkthrough.
File:markdown/schema-registry-beta/schema-registry.md (144-144)🧾 Readability - Non-standard markdown syntax may fail to render properly across different markdown processors.
Details: The documentation uses [!NOTE] syntax which is not standard markdown and may not render correctly in all markdown processors, potentially causing display issues.
File:markdown/schema-registry-beta/schema-registry.md
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
There was a problem hiding this comment.
✨ PR Review
The documentation has been significantly updated to focus on Solace Schema Registry instead of Apicurio Registry, with improved consistency in terminology. However, there are still some incomplete placeholder content and command syntax errors that need to be addressed.
3 issues detected:
🧾 Readability - The word "postive" should be "positive" on line 77.
Details: There is a spelling error in the markdown aside directive that could affect document rendering or readability.
File:markdown/schema-registry-beta/schema-registry.md (77-77)🐞 Bug - The Windows command contains duplicate patterns "docker-images\*.tar.gz \*.tar.gz" which will cause command execution errors.
Details: The Windows command for loading Docker images contains duplicate file patterns that will cause execution failures when users attempt to run the command.
File:markdown/schema-registry-beta/schema-registry.md (93-93)🧾 Readability - The documentation contains an unfinished "Insert image" placeholder.
Details: The documentation contains an "Insert image" placeholder that indicates incomplete content and will confuse users who expect a complete walkthrough.
File:markdown/schema-registry-beta/schema-registry.md (143-143)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
There was a problem hiding this comment.
✨ PR Review
The PR successfully updates the schema registry documentation from beta to GA version with comprehensive improvements including better structure, consistent terminology, and updated examples. However, several previously identified issues remain unresolved.
3 issues detected:
🐞 Bug - Typo in the word "positive" spelled as "postive"
Details: The markdown aside directive contains a spelling error that affects readability and document professionalism.
File:markdown/schema-registry-beta/schema-registry.md (77-77)🐞 Bug - Windows command contains duplicate file patterns causing syntax errors
Details: The Windows command for loading Docker images contains duplicate file patterns that will cause execution failures when users attempt to run the command on Windows systems.
File:markdown/schema-registry-beta/schema-registry.md (93-93)🧹 Maintainability - Placeholder text "Insert image" indicates incomplete documentation
Details: The documentation contains an "Insert image" placeholder that indicates incomplete content and will confuse users who expect a complete walkthrough.
File:markdown/schema-registry-beta/schema-registry.md (143-143)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
There was a problem hiding this comment.
✨ PR Review
The PR successfully updates the documentation from Apicurio Registry to Solace Schema Registry with comprehensive content covering both Docker and Kubernetes deployments. However, there are still some unfinished elements and command syntax issues that need to be addressed.
2 issues detected:
🐞 Bug - The command contains duplicate file patterns "\*.tar.gz" that will cause syntax errors during execution.
Details: The Windows command for loading Docker images contains duplicate file patterns that will cause execution failures when users attempt to run the command on Windows systems.
File:markdown/schema-registry-beta/schema-registry.md (93-93)🧾 Readability - Placeholder text "Insert image" appears in the final documentation instead of actual content.
Details: The documentation contains an "Insert image" placeholder that indicates incomplete content and will confuse users who expect a complete walkthrough.
File:markdown/schema-registry-beta/schema-registry.md (143-143)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
removed old images, added small fixes and sample images for creating RDP
There was a problem hiding this comment.
✨ PR Review
The PR successfully updates the documentation from beta to GA, changing focus from Apicurio Registry to Solace Schema Registry and from Avro to JSON schemas. However, some previously identified issues remain unresolved.
2 issues detected:
🐞 Bug - The command has redundant file pattern specification that will cause syntax errors during execution.
Details: The Windows command for loading Docker images contains duplicate file patterns that will cause execution failures when users attempt to run the command on Windows systems.
File:markdown/schema-registry-beta/schema-registry.md (93-93)🧾 Readability - Placeholder text indicates unfinished documentation content.
Details: The documentation contains an "Insert image" placeholder that indicates incomplete content and will confuse users who expect a complete walkthrough.
File:markdown/schema-registry-beta/schema-registry.md (143-143)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
sdewilde
left a comment
There was a problem hiding this comment.
The actual codelab HTML still calls this the beta and mentions apicurio. We can't only change the markdown folder
|
New code lab looks good |
Chaymee
left a comment
There was a problem hiding this comment.
New codelab looks good to go with minor changes

✨ PR Description
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀