feat(constraint): Improve SurfacePressureConstraint logic and fix bug #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a bug in the `SurfacePressureConstraintResolution` where the force was incorrectly calculated due to a flawed `if/if/else` control flow. The logic has been corrected to a proper `if/else if/else` structure. Additionally, the clamping logic in `VolumeGrowthConstraintResolution` has been refactored to use `std::min` and `std::max`, improving code clarity and conciseness.
Refactors the `getCavityVolume` function in `SurfacePressureModel` to improve readability and reduce code duplication. The volume calculation for a single tetrahedron has been extracted into a new private helper function, `getTetrahedronVolume`. This change makes the overall volume computation logic easier to follow without altering the underlying algorithm.
src/SoftRobots/component/constraint/model/SurfacePressureModel.h
Outdated
Show resolved
Hide resolved
Member
|
I've merged with master to fix the failing tests on the CI |
EulalieCoevoet
requested changes
Feb 4, 2026
src/SoftRobots/component/constraint/model/SurfacePressureModel.h
Outdated
Show resolved
Hide resolved
src/SoftRobots/component/constraint/model/SurfacePressureModel.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots/component/constraint/model/SurfacePressureModel.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots/component/constraint/model/SurfacePressureModel.inl
Outdated
Show resolved
Hide resolved
src/SoftRobots/component/constraint/model/SurfacePressureModel.inl
Outdated
Show resolved
Hide resolved
EulalieCoevoet
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a bug in the
SurfacePressureConstraintResolutionwhere the force was incorrectly calculated due to a flawedif/if/elsecontrol flow. The logic has been corrected to a properif/else if/elsestructure.Additionally, the clamping logic in
VolumeGrowthConstraintResolutionhas been refactored to usestd::minandstd::max, improving code clarity and conciseness.