Revert "Audit Issue 9: Enforce single payload (#1654)"#1705
Merged
Conversation
This reverts commit 3c26e64.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 81.04% 81.30% +0.26%
==========================================
Files 22 22
Lines 997 995 -2
Branches 186 185 -1
==========================================
+ Hits 808 809 +1
+ Misses 172 169 -3
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vgeddes
reviewed
Feb 10, 2026
contracts/src/BeefyClient.sol
Outdated
| revert CommitmentNotRelevant(); | ||
| for (uint256 i = 0; i < commitment.payload.length; i++) { | ||
| if (commitment.payload[i].payloadID == MMR_ROOT_ID) { | ||
| if (commitment.payload[i].data.length != 32) { |
Collaborator
There was a problem hiding this comment.
I think this check is unnecessary, if Parity changes the length that would break everything. We can save gas here.
vgeddes
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c26e64.