Add user impersonation from credentials #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this pull request add the
--usernameand--passwordoptions, which when specified, will authenticate and impersonate the given user.This will allow Snaffler to operate as if it were being run in the context of another domain user without having to run the tool while logged in as that user. By default, if a domain is not specified, it will use the domain of the current user, and if a password is not specified it will default to an empty string.
I have tested the changes here and they seem to work, but it is possible I am missing something since I am not the most familiar with this tool. I am able to get access to a share that only the impersonated user has access to.