refactor(item): Rewrote the entire library#32
Open
BPR02 wants to merge 6 commits intoSmithed-MC:mainfrom
Open
Conversation
Contributor
BPR02
commented
Jul 9, 2023
BPR02
commented
- Rewrote code to be more readable
- Documented the code
- Optimized functionality
- Added a feature to prevent complete destruction of the item
- Fixed some bugs
- bumped version to 0.3.0 (breaking, but still zero major)
- Rewrote code to be more readable - Documented the code - Optimized functionality - Fixed some bugs
accidentally forgot to change the patch to 0
Contributor
Author
|
This has a breaking change: I renamed the public API calls from |
Collaborator
|
Should this be a draft PR still? |
Contributor
Author
Yeah, Coppertine is doing some bolt work |
- add in-code documentation to how the lore builder works - use `smithed.item` scoreboard instead of `smithed.data` - made "Unbreakable" lore consistent with vanilla (items are unbreakable if `Unbreakable` is a non-zero numeric tag) - fixed attribute paths not being versioned - removed empty function
- fix unbreakable check to only allow numeric tags (int, short, long, byte) - remove unnecessary xp scoreboards
Collaborator
|
@BluePsychoRanger i realize this PR has been stale for a bit but what exactly is the state of this again? i see that it's ready for review, should I just look thru and merge? CC @asdru22 |
Contributor
Author
|
This PR is ready for review then merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.