WWSTCERT-8279 add screen VIVIDSTORM VWSDSTUST120H #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 456 suites 0s ⏱️ Results for commit 8c40cc2. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8c40cc2 |
pInksenberg
reviewed
Oct 9, 2025
|
|
||
| local timer = device:get_field(TIMER) | ||
| if timer ~= nil then driver:cancel_timer(timer) end | ||
| timer = device.thread:call_with_delay(5, function(d) |
There was a problem hiding this comment.
Is the 5 sec timer set properly? Does this 5 sec interval work well for curtain tracks of different lengths?
There was a problem hiding this comment.
The current experimental data is only applicable to this product. For other products, adjustments will be made based on the test results in the future.
greens
changed the title
greens
reviewed
Oct 14, 2025
Comment on lines
99
to
143
| if command.args.mode == "Delete upper limit" then | ||
| device:send( | ||
| cluster_base.write_manufacturer_specific_attribute( | ||
| device, | ||
| custom_clusters.motor.id, | ||
| custom_clusters.motor.attributes.mode_value.id, | ||
| custom_clusters.motor.mfg_specific_code, | ||
| custom_clusters.motor.attributes.mode_value.value_type, | ||
| 0 | ||
| ) | ||
| ) | ||
| elseif command.args.mode == "Set the upper limit" then | ||
| device:send( | ||
| cluster_base.write_manufacturer_specific_attribute( | ||
| device, | ||
| custom_clusters.motor.id, | ||
| custom_clusters.motor.attributes.mode_value.id, | ||
| custom_clusters.motor.mfg_specific_code, | ||
| custom_clusters.motor.attributes.mode_value.value_type, | ||
| 1 | ||
| ) | ||
| ) | ||
| elseif command.args.mode == "Delete lower limit" then | ||
| device:send( | ||
| cluster_base.write_manufacturer_specific_attribute( | ||
| device, | ||
| custom_clusters.motor.id, | ||
| custom_clusters.motor.attributes.mode_value.id, | ||
| custom_clusters.motor.mfg_specific_code, | ||
| custom_clusters.motor.attributes.mode_value.value_type, | ||
| 2 | ||
| ) | ||
| ) | ||
| elseif command.args.mode == "Set the lower limit" then | ||
| device:send( | ||
| cluster_base.write_manufacturer_specific_attribute( | ||
| device, | ||
| custom_clusters.motor.id, | ||
| custom_clusters.motor.attributes.mode_value.id, | ||
| custom_clusters.motor.mfg_specific_code, | ||
| custom_clusters.motor.attributes.mode_value.value_type, | ||
| 3 | ||
| ) | ||
| ) | ||
| end |
There was a problem hiding this comment.
local value_map = {
"Delete upper limit" = 0,
...
}
local value = value_map[command.args.mode]
if value ~= nil then device:send(cluster_base.write_manufacturer_specific_attribute(..., value) end
greens
reviewed
Oct 14, 2025
Comment on lines
175
to
182
| [WindowCovering.ID] = { | ||
| [WindowCovering.attributes.CurrentPositionLiftPercentage.ID] = liftPercentage_attr_handler | ||
| }, | ||
| [custom_clusters.motor.id] = { | ||
| [custom_clusters.motor.attributes.mode_value.id] = mode_attr_handler, | ||
| [custom_clusters.motor.attributes.hardwareFault.id] = hardwareFault_attr_handler | ||
| } | ||
| } |
greens
reviewed
Oct 14, 2025
drivers/SmartThings/zigbee-window-treatment/profiles/projector-screen-VWSDSTUST120H.yml
Show resolved
Hide resolved
|
thinkaName
force-pushed
the
VWSDSTUST120H
branch
from
23d156c to
66eff70
Compare
greens
reviewed
Oct 15, 2025
| version: 1 | ||
| - id: firmwareUpdate | ||
| version: 1 | ||
| - id: refresh |
There was a problem hiding this comment.
missing the version field here, which is why your test failed
There was a problem hiding this comment.
This issue has been resolved
thinkaName
force-pushed
the
VWSDSTUST120H
branch
from
66eff70 to
8c40cc2
Compare
greens
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests