Support robotCleanerOperatingState Routine #2443
Conversation
Signed-off-by: Hunsup Jung <[email protected]>
Signed-off-by: Hunsup Jung <[email protected]>
|
Invitation URL: |
Test Results 71 files 455 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 0ced929. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0ced929 |
Signed-off-by: Hunsup Jung <[email protected]>
HunsupJung
force-pushed
the
feature/update-rvc-routine
branch
from
388bea7 to
9ce965f
Compare
| @@ -0,0 +1,108 @@ | |||
| name: Robot Cleaner Operating State | |||
There was a problem hiding this comment.
Hey @HunsupJung why do we need this capability to be embedded? It appears the same capability def is already deployed in production
There was a problem hiding this comment.
Yes, the capability def is already deployed in production, but it is not applied in scripting-engine, so if the def is not added, test action is failed in this PR.
Could you update the scripting-engine like Tom did before? After that we can remove the capability def.
https://github.ecodesamsung.com/iot-hub/scripting-engine/pulls?q=is%3Apr+author%3Atpmanley+is%3Aclosed
- AcceptedCommandList file and GoHome file for lower lua lib integration - Add augment_type() for lower lua lib integraiton - Replacing with get_latest_state() Signed-off-by: Hunsup Jung <[email protected]>
| if supported_areas ~= nil then | ||
| for i, area in ipairs(supported_areas) do | ||
| table.insert(selected_areas, area.areaId) | ||
| end |
There was a problem hiding this comment.
| if supported_areas ~= nil then | |
| for i, area in ipairs(supported_areas) do | |
| table.insert(selected_areas, area.areaId) | |
| end | |
| for i, area in ipairs(supported_areas or {}) do | |
| table.insert(selected_areas, area.areaId) | |
| end |
Signed-off-by: Hunsup Jung <[email protected]>
|
@hcarter-775 |
2 participants
Type of Change
Checklist
Description of Change
This PR is for supporting Routine of
robotCleanerOperatingStateCapability and includes follows.rvc_operational_state_list_attr_handlerhas been added to support Condition of Routine.handle_rvc_operational_state_accepted_command_listhas been updated to updatesupportedCommandsdriverSwitchedhas been added to executehandle_rvc_operational_state_accepted_command_listafter updating driver.Summary of Completed Tests