This repository was archived by the owner on Jun 2, 2023. It is now read-only.
Partial V6 refactoring#37
Open
TheSleepyCraftsman wants to merge 10 commits intoSlotterleet:masterfrom
Open
Conversation
Objectives.Research requirements in planets.js was causing a nullpointer error when attempting to complete stained mountains.
Owner
|
Author
|
Let me review this again. First time I have ever attempted to do a pull
request, etc.
1. Hmm. I thought I had fixed that. I know research objectives don't
work. Unlocks based on sectors should.
2. Compatibility with V6. Couldn't determine what the equivalent
parameter name should be.
3. I tend to agree. I only did this because of my limited experience
with javascript. I couldn't figure out how to reference something from
another file. Yes, I have no idea what I am doing.
4. IDE Settings I guess. I used JetBrains IntelliJ IDEA as my editor.
…On Mon, Mar 29, 2021, 10:44 AM TheSlaylord ***@***.***> wrote:
1. Sectors *mustn't* be always unlocked. It will be fixed immediately
once I find out how to add objectives.
2. Why did you remove some of turrets' properties?
3. I don't see any reasons to merge planet scripts to a single file.
4)* What is that .idea folder? (Just asking bc I have no clue what it
is)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATGNZUZ6DUQEENX7LZIW3NLTGCG5LANCNFSM4ZHTKKDA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not perfect, but it appears to be working, including research points.
FYI:
Campaign progression doesn't work. Manually unlocked the maps. No clue how to refactor old zone content objectives to V6 rules.
Not all maps have been added to serpulo.js.