Add new packet recieve type: LED Blink Offset#274
Open
nullstalgia wants to merge 3 commits intoSlimeVR:mainfrom
Open
Add new packet recieve type: LED Blink Offset#274nullstalgia wants to merge 3 commits intoSlimeVR:mainfrom
nullstalgia wants to merge 3 commits intoSlimeVR:mainfrom
Conversation
Member
|
Is this really necessary... |
Contributor
Author
|
Absolutely necessary? No. But it's something that myself and others have discussed in the discord before as a cute nice-to-have, and it's not taking up massive amount of resources on either the server or tracker side. I opened the issue in November of 2022 and since no one else took up the mantle (or shut it down), myself and Uriel were discussing it after another person was asking about it. We decided to make it a reality together, since I knew the ESP side better than the Kotlin side, and visa versa. |
unlogisch04
added
the
Status: Blocked by other issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses (but does not close) issue 301 of the SlimeVR Server.
This allows the server to send a packet to the tracker with a uint32_t value that contains the delay before it should (re)start the normal blinking loop.
Used for syncing the blinks together, or set up an order in which trackers should blink with incrementing offsets.