Implement file upload without name test#12
Merged
lyaunzbe merged 1 commit intoSkycatch:masterfrom Oct 6, 2015
Merged
Conversation
srt32
force-pushed
the
st-basic-test-suite
branch
from
ac1e35c to
9f73f73
Compare
Contributor
Author
There was a problem hiding this comment.
This import was not used.
* Adds a test for `files.upload` (without custom name). * Adds `nock` as a `devDependency` for testing. I'd enjoy any feedback on the approach I took and would also be happy to add coverage to some of the other functions if we're happy with the general direction here. Conversation started in Skycatch#3 (comment)
srt32
force-pushed
the
st-basic-test-suite
branch
from
9f73f73 to
aaf2b04
Compare
|
👍 |
Contributor
Author
|
Ping @lyaunzbe, curious about your thoughts. |
Contributor
|
LGTM. Thanks! You are more than welcome to add additional coverage for other functions, it is much appreciated! |
lyaunzbe
added a commit
that referenced
this pull request
Oct 6, 2015
Implement file upload without name test
Contributor
Author
|
Great, thanks! @lyaunzbe what would you think about setting up CI (maybe using http://circleci.com/) for this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
files.upload(without custom name).nockas adevDependencyfor testing.I'd enjoy any feedback on the approach I took and would also be happy to
add coverage to some of the other functions if we're happy with the
general direction here.
Conversation started in
#3 (comment)