Skip to content

Use eclipse-temurin image instead of deprecated openjdk #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

Use eclipse-temurin image instead of deprecated openjdk #139

merged 1 commit into from
Nov 28, 2025
+11 −10

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 27, 2025 •
edited
Loading

Description

Use eclipse-temurin image instead of deprecated openjdk

@mmorel-35 mmorel-35 force-pushed the openjdk branch 2 times, most recently from b4b1a32 to 98e7b42 Compare November 27, 2025 07:43
@mmorel-35 mmorel-35 changed the title Update openjdk from 8 to 13 Update openjdk from 8 to 17 Nov 27, 2025
@mmorel-35 mmorel-35 force-pushed the openjdk branch 3 times, most recently from fd3fe5a to 6b3d557 Compare November 27, 2025 07:49
@mmorel-35 mmorel-35 changed the title Update openjdk from 8 to 17 Update openjdk from 8 to eclipse-temurin 11 Nov 27, 2025
wu-sheng
wu-sheng previously approved these changes Nov 27, 2025
View reviewed changes
@mmorel-35 mmorel-35 changed the title Update openjdk from 8 to eclipse-temurin 11 Use eclipse-temurin image instead of deprecated openjdk Nov 27, 2025
@wu-sheng
Copy link
Member

wu-sheng commented Nov 27, 2025

The JDK change should be seamless, I am not sure why it breaks. Please check locally.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 27, 2025

Something else than an outdated image is going wrong :

#22 64.01 /tests/mock-collector/bin/fetch_code.sh: line 19: git: command not found
#22 64.01 /tests/mock-collector/bin/fetch_code.sh: line 21: cd: /tests/mock-collector/target/protocol: No such file or directory
#22 64.01 [ERROR] Command execution failed.
#22 64.02 org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
#22 64.02     at org.apache.commons.exec.DefaultExecutor.executeInternal (DefaultExecutor.java:404)
#22 64.02     at org.apache.commons.exec.DefaultExecutor.execute (DefaultExecutor.java:166)
#22 64.02     at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:804)
#22 64.02     at org.codehaus.mojo.exec.ExecMojo.executeCommandLine (ExecMojo.java:751)
#22 64.02     at org.codehaus.mojo.exec.ExecMojo.execute (ExecMojo.java:313)
#22 64.02     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
#22 64.02     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
#22 64.02     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
#22 64.02     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
#22 64.02     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
#22 64.02     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
#22 64.02     at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
#22 64.02     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
#22 64.02     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
#22 64.02     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
#22 64.02     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
#22 64.02     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
#22 64.02     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
#22 64.02     at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
#22 64.02     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
#22 64.02     at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
#22 64.02     at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
#22 64.02     at java.lang.reflect.Method.invoke (Method.java:498)
#22 64.02     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
#22 64.02     at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
#22 64.02     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
#22 64.02     at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
#22 64.03     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
#22 64.03     at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
#22 64.03     at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
#22 64.03     at java.lang.reflect.Method.invoke (Method.java:498)
#22 64.03     at org.apache.maven.wrapper.BootstrapMainStarter.start (BootstrapMainStarter.java:39)
#22 64.03     at org.apache.maven.wrapper.WrapperExecutor.execute (WrapperExecutor.java:122)
#22 64.03     at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:61)

@wu-sheng
Copy link
Member

wu-sheng commented Nov 27, 2025

It seems the new image removed the git command. We may need extra step to install git first.

@mmorel-35 mmorel-35 requested a review from wu-sheng November 27, 2025 17:59
@wu-sheng wu-sheng merged commit 798112a into SkyAPM:main Nov 28, 2025
4 checks passed
@mmorel-35 mmorel-35 deleted the openjdk branch November 28, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmorel-35 @wu-sheng