Optimize looping reversed lists #8335
Merged
+189
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
added
the
enhancement
UnderscoreTud
requested review from
Burbulinis and
TheMug06
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
requested changes
Dec 30, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
good idea tud
we should be implementing iterator more often tbh
sovdeeth
approved these changes
Dec 30, 2025
erenkarakal
approved these changes
Dec 30, 2025
skriptlang-automation
bot
added
patch-ready
APickledWalrus
approved these changes
Dec 30, 2025
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.14 Releases
skriptlang-automation
bot
added
completed
APickledWalrus
moved this from Done - Awaiting Release
to Done - Released
in 2.14 Releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When looping trying to loop in reverse, Skript constructs a whole new array in reverse order then loops it
Solution
Implement the
iteratormethod for ExprReversedList that iterates over the array in reverse order without constructing a new arrayTesting Completed
ExprReversedList.skand manual testingSupporting Information
Completes: none
Related: none
AI assistance: none