Skip to content

Conversation

@sovdeeth
Copy link
Member

Problem

Exception thrown when setting yaw/pitch to non-finite values

[18:18:53 ERROR]: #!#! Stack trace:
[18:18:53 ERROR]: #!#! Caused by: java.lang.IllegalArgumentException: pitch not finite
[18:18:53 ERROR]: #!#!     at org.bukkit.util.NumberConversions.checkFinite(NumberConversions.java:124)
[18:18:53 ERROR]: #!#!     at org.bukkit.craftbukkit.entity.CraftEntity.setRotation(CraftEntity.java:270)
[18:18:53 ERROR]: #!#!     at Skript-2.13.2.jar//ch.njol.skript.expressions.ExprYawPitch.changeForEntity(ExprYawPitch.java:117)

Solution

Don't change if value is non-finite. Also removes VectorMath as it has been deprecated since 2.10, plus a few other minor touchups to ExprYawPitch

Testing Completed

Added a regression test.

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Dec 29, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner December 29, 2025 23:51
@sovdeeth sovdeeth requested review from cheeezburga and erenkarakal and removed request for a team December 29, 2025 23:51
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Dec 29, 2025
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Dec 29, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Jan 1, 2026
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jan 1, 2026
@APickledWalrus APickledWalrus merged commit 96b8309 into SkriptLang:dev/feature Jan 1, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 1, 2026
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jan 1, 2026
@APickledWalrus APickledWalrus moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants