This repository was archived by the owner on Sep 3, 2021. It is now read-only.
Use shutil.which to find 'winetricks' instead of hardcoded path#34
Closed
Matoking wants to merge 1 commit intoSirmentio:masterfrom
Closed
Use shutil.which to find 'winetricks' instead of hardcoded path#34Matoking wants to merge 1 commit intoSirmentio:masterfrom
Matoking wants to merge 1 commit intoSirmentio:masterfrom
Conversation
Matoking
force-pushed
the
shutil_which
branch
from
6c6b1ba to
024d6e0
Compare
|
What happens if the user doesn't have a $PATH environment variable set for winetricks? |
Contributor
Author
If you mean that winetricks is installed in a location not found in $PATH, then you have to supply it manually using $WINETRICKS or add the needed path into $PATH. Otherwise protontricks will complain that it can't find winetricks. |
Matoking
force-pushed
the
shutil_which
branch
from
024d6e0 to
164aca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Instead of looking for winetricks in hardcoded paths, just use user's $PATH environment variable to find the executable, just as a shell would intuitively do.