chore: register terasologylauncher as a GDD component - #28
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR registers TerasologyLauncher as a tier-3 ecosystem component and adds Gradle build, test, lint, run, and clean commands with a README context pointer. ChangesTerasologyLauncher integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@adapters/terasologylauncher.yaml`:
- Line 3: Update the TerasologyLauncher adapter’s build command from the Gradle
jar-only task to the documented build task, so the build flow compiles sources,
runs tests, and creates the JAR when invoking the adapter’s build operation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: db7570df-b482-4c66-a040-b31b9cadc456
📒 Files selected for processing (2)
adapters/terasologylauncher.yamlecosystem.yaml
| @@ -0,0 +1,11 @@ | |||
| # terasologylauncher adapter — build/test commands and AI context pointers | |||
| commands: | |||
| build: "./gradlew jar" | |||
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== candidate repo files =="
git ls-files | rg '(^|/)(README\.md|gradle\.properties|settings\.gradle|build\.gradle(\.kts)?|terasologylauncher\.yaml)$' || true
echo
echo "== adapters/terasologylauncher.yaml =="
if [ -f adapters/terasologylauncher.yaml ]; then
cat -n adapters/terasologylauncher.yaml
fi
echo
echo "== Gradle build command occurrences in READMEs =="
for f in $(git ls-files | rg 'README\.md$'); do
if rg -n "gradlew build|build task|run tests|compiling" "$f" >/dev/null; then
echo "--- $f"
rg -n -C 3 "gradlew build|Build the project|building the JAR|build task|run tests|tests?|gradlew jar" "$f" || true
fi
done
echo
echo "== TerasologyLauncher gradle files =="
for f in $(git ls-files | rg 'TerasologyLauncher.*gradle|build\.gradle|settings\.gradle'); do
if echo "$f" | rg 'Terasol|terasology|build\.gradle|settings\.gradle' >/dev/null; then
echo "--- $f"
sed -n '1,220p' "$f"
fi
doneRepository: SiliconSaga/realm-siliconsaga
Length of output: 839
🌐 Web query:
MovingBlocks TerasologyLauncher README gradlew build compile run tests build JAR
💡 Result:
To build, compile, and run the TerasologyLauncher from source, you can utilize the Gradle wrapper (gradlew) provided in the repository [1][2]. The following commands are commonly used for development and building [1][2]: gradlew build: Compiles the source code, runs the tests, and builds a JAR file [1][2]. gradlew run: Builds and runs the launcher [1][2]. gradlew install: Creates a local runnable installation of the launcher, which is placed in the./build/install/TerasologyLauncher directory [1][2]. gradlew createRelease: Creates a local development release, which is located in the./build/distributions directory [1][2]. gradlew tasks: Displays a list of all other available build script tasks [1][2]. The project documentation recommends using IntelliJ IDEA for development, though other setups are possible [1][2]. For additional information on contributing and development workflows, you can refer to the CONTRIBUTING.md file in the repository [1][3].
Citations:
- 1: https://github.com/MovingBlocks/TerasologyLauncher/blob/master/README.md
- 2: https://github.com/MovingBlocks/TerasologyLauncher/tree/v4.8.0
- 3: https://github.com/MovingBlocks/TerasologyLauncher/blob/master/docs/CONTRIBUTING.md
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
import re
from urllib.request import urlopen
import ssl
ssl_ctx = ssl.create_default_context()
ssl_ctx.check_hostname = False
ssl_ctx.verify_mode = ssl.CERT_NONE
urls = [
"https://raw.githubusercontent.com/MovingBlocks/TerasologyLauncher/master/README.md",
"https://raw.githubusercontent.com/MovingBlocks/TerasologyLauncher/master/build.gradle",
]
for url in urls:
print(f"\n== {url} ==")
try:
text = urlopen(url, context=ssl_ctx, timeout=30).read().decode("utf-8")
print("lines:", len(text.splitlines()))
# Extract relevant Gradle sections and README build section.
for pat in [r"gradlew build:(.*?)(?:\n\n|\n[`]{3}\n|$)", r"build\s*\{", r"tasks\.jar"], re.S:
for m in re.finditer(pat, text):
snippet = m.group(0).splitlines()[:80]
print(f"\n--- pattern: {pat[:60]} ---")
for line in snippet:
print(line)
except Exception as e:
print(f"ERROR: {e}")
PY
echo
echo "== local adapter snippet =="
sed -n '1,20p' adapters/terasologylauncher.yamlRepository: SiliconSaga/realm-siliconsaga
Length of output: 794
Use the documented build task.
./gradlew jar only runs the JAR task. The upstream TerasologyLauncher README defines gradlew build as compiling the source, running the tests, and building the JAR. With the current mapping, ws build terasologylauncher can succeed without those build checks.
Proposed fix
- build: "./gradlew jar"
+ build: "./gradlew build"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| build: "./gradlew jar" | |
| build: "./gradlew build" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@adapters/terasologylauncher.yaml` at line 3, Update the TerasologyLauncher
adapter’s build command from the Gradle jar-only task to the documented build
task, so the build flow compiles sources, runs tests, and creates the JAR when
invoking the adapter’s build operation.
22c4aff to
c7efd55
Compare
`jar` skips tests. `build` compiles, tests, jars — matches upstream README. CodeRabbit finding on SiliconSaga#28. Co-Authored-By: soloturn <soloturn@gmail.com>
1 participant
Summary
terasologylauncheras a GDD component (supporting tier, no forkRepo — fork destination is per-user, not fixed here).Test plan
ws clone terasologylaunchersucceeds.Related