Fix timestamp handling when paired with |gt |gte |lt and |lte…

[Res260]

Fix timestamp handling when paired with |gt |gte |lt and |lte modifiers.
Big oversight on my part, sorry!

[Res260]

@thomaspatzke I'm not too sure what I did wrong about the typing. Help would be appreciated 🙏

[thomaspatzke]

@thomaspatzke I'm not too sure what I did wrong about the typing. Help would be appreciated 🙏

I recently merged the large refactoring branch into main and since then mypy type checks are enforced. The findings are:

sigma/conversion/base.py:1814: error: Item "None" of "Optional[str]" has no attribute "format" [union-attr]

Your code expects that the object you call format() is a string but it might also be None. This should be checked before and raise a NotImplementedError if the template isn't set.

sigma/conversion/base.py:1816: error: Value of type "Optional[dict[TimestampPart, str]]" is not indexable [index]

Unsure but it could be that the reason here is also that a value is possibly None.

[Res260]

Should be good now! Thanks