fixes to documentation#1697
Merged
Merged
Conversation
kdayday
reviewed
Jun 11, 2026
| ## The "Starbus" Representation | ||
|
|
||
| The resulting $Z_{12}, Z_{23},$ and $Z_{13}$ represent the series impedances in a star network. The common point of this star network is the conceptual "starbus" or internal neutral node. Each winding's terminal in the power system network is then connected to its corresponding impedance in this equivalent star. | ||
| The measured pairwise leakage impedances $Z_{12}, Z_{23},$ and $Z_{13}$ between each pair of windings are converted into the equivalent star impedances $Z_1, Z_2,$ and $Z_3$. The common point of this star network is the conceptual "starbus" or internal neutral node. Each winding's terminal in the power system network is then connected to its corresponding impedance in this equivalent star. |
Contributor
There was a problem hiding this comment.
@jd-lara I leave this to you to verify correctness on this point
kdayday
approved these changes
Jun 11, 2026
kdayday
left a comment
Contributor
There was a problem hiding this comment.
Left one question for you on rework of the starbus page, otherwise looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from Fable review of #1635.
Correctness fixes (would mislead users or error if run)
how_to/convert_transformer_impedance.md: the example transformer'sratingwas set as0.5labeled "SYSTEM_BASE p.u." —ratingis stored on the device base, so the example silently encoded 25 MVA instead of 50 MVA. Nowrating = 1.0on the device base.how_to/use_context_managers.md: thebegin_supplemental_attributes_updateexample constructedFixedForcedOutage(; mean_time_to_recovery, mean_time_to_failure)— neither field exists on that struct. Replaced with a validGeometricDistributionForcedOutageexample.how_to/link_hydro_reservoirs_to_turbines.md: example 2 rebuiltsys/busfrom scratch but then linked the reservoir from the discarded first system. The page now uses oneSystemthroughout.Math / semantics precision
per_unit.md+convert_transformer_impedance.md: getters apply only the MVA-ratio part of the base conversion; added an explicit warning that the voltage-ratio correction is assumed to be 1 (rated voltage = bus base voltage) and must otherwise be applied manually.three_winding_transformers.md:WINDV/NOMV/ANG/SBASE1-2field names verified against the PTI parser).get_component(sys, uuid)/get_available_component(sys, uuid)throwArgumentErroron a missing UUID (they do not returnnothing)add_subsystem!throwsIS.InvalidValuewhen subsystems would exceed the bus countStorage's only concrete subtype isEnergyReservoirStorage(HybridSystemis aStaticInjectionSubsystem)get_serviceserrors (not "returns empty") for devices that don't support servicesmonitored_componentsfieldcalculate_IM_torque_params:Ais the quadratic andBthe linear torque-speed term (C = 1 − A − Bis the constant)rating_b/rating_care second/third ratings (RATE_B/RATE_C), not winding sidesget_from_bus/get_to_busreturnBus(DC branches haveDCBusendpoints)Servicesubtype list now includesConstantReserveGroup;ImportExportCostweekly_limits→weekly_limittypos; backtick/apostrophe typos incost_function_timeseries.jlget_associated_supplemental_attributesdocstring signature and example matched to the actual functionDERA1entry, fixed the doubledREPCA1label, and corrected the claim thatExponentialLoadis a ZIP model.buses_type_explanation.md: removed a garbled duplicated sentence and fixedRef:→REF.Verbosity reduction (~190 net lines)
use_context_managers.md: removed duplicated/incorrect supplemental-attribute examples (now links to the dedicated how-to), the near-clone time-series example, and the redundant "Best Practices" section.explanation/transformer_per_unit_models.md(content verbatim inper_unit.mdand the page was dropped from nav); retargeted the two@ref transformers_pulinks totransformers_pu_per_unit.power_concepts.md: collapsed the triple statement of units/getters into the summary table.supplemental_attributes.md: merged the "Benefits" and "Compared to other approaches" sections into the motivation paragraph.add_supplemental_attributes.md: merged the near-identical bulk and shared-attribute examples.time_series.md: the "Multiple Forecast Intervals" code blocks duplicated the tutorial call-for-call; kept the concept, linked the tutorial.working_with_time_series.jl: trimmed the re-inspection tail that re-printed components and re-explained an earlier point.manipulating_datasets.jl: dot-access warning now links to@ref dot_accessinstead of duplicatingsystem.md(and drops the hardcoded stable URL).dynamic_data.md: deduplicated the static/dynamic two-layer explanation.Verification
julia --project=test test/runtests.jl: 11735/11735 passComponentContainer,InfrastructureSystemsComponent,InfrastructureSystemsInternalfallbacks). No errors from files changed here; all modified@exampleblocks execute.Not addressed (pre-existing, out of scope for a docs PR)
power_system_structs.jsondescriptor comments forTransformer2Wr/x/ratingstill say "pu (SYSTEM_BASE)" while runtime behavior (and the new docs) are device base — needs a descriptor + regeneration pass.HybridSystem.jlsettersset_electric_load!/set_storage!/set_renewable_unit!/set_interconnection_efficiency!reference an undefined variable and wouldUndefVarErrorif called — behavioral bug, should be a separate issue/PR.🤖 Generated with Claude Code