Claude/inspiring johnson pqzkyz by jd-lara · Pull Request #1695 · Sienna-Platform/PowerSystems.jl

jd-lara · 2026-06-10T22:15:17Z

Relies on the companion IS branch Sienna-Platform/InfrastructureSystems.jl#585

…control traits for StaticInjection types Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/b4e1573e-353e-4de2-a675-beeeb8ddbd2e

…ontrol_mode and bus type Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/65d79b71-2f1c-4c06-b213-6b72d532bed5

…omment Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/65d79b71-2f1c-4c06-b213-6b72d532bed5

…e for NML mode) Co-authored-by: m-bossart <67015312+m-bossart@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/4e8ef608-6efd-4060-b37e-d9bbcfceef46

…ride) Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/48a5642f-e0b8-4fac-b6fa-a26153919ad0

…bus is never nothing) Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/514ef393-9a13-4754-bbd1-ccff32acb69b

…-static-injectors

Minor Fix: docs badge link

…ons-build-job Fix broken SupplementalAttribute docs cross-reference

Deep multi-agent review of the IS4 (InfrastructureSystems) and psy6 units-management rework: 18 verified correctness findings, API hygiene, consolidation refactors, performance items, and a clean security pass. Written as a phased work order for a follow-up implementation session. https://claude.ai/code/session_013x42ojzmA6xjkgxQxriteV

…tatic-injectors Add traits to static injectors about active power, reactive power, voltage control

…son-pqzkyz # Conflicts: # test/test_devices.jl

Copilot

Pull request overview

This PR updates PowerSystems.jl’s unit-conversion and accessor plumbing (explicit unit arguments, safer conversions for detached components, and improved quantity serialization), fixes/strengthens branch validation and logging, and re-enables a large set of integration tests that were previously commented out.

Changes:

Harden unit conversion/serialization: base-voltage-required conversions now error clearly; DU↔SU conversions avoid unnecessary base-voltage access; RelativeQuantity serialization uses the unit type parameter.
Improve robustness of display/printing and branch validation (including a fixed voltage-limit bug in line_rating_calculation and clearer negative-rating error logs).
Re-enable substantial end-to-end test coverage (topology, services, serialization, hybrid system, bus numbering, printing) and expand unit/base-power regression tests.

Reviewed changes

Copilot reviewed 36 out of 77 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/test_units.jl	Adds unit-conversion regression tests, including base-voltage-missing error behavior.
test/test_topology.jl	Re-enables topology mapping and aggregation-topology tests.
test/test_subsystems.jl	Re-enables subsystem consistency tests, including hybrid subsystem behavior.
test/test_services.jl	Re-enables service removal and TransmissionInterface tests.
test/test_serialization.jl	Re-enables multiple serialization/deserialization testsets (RTS/matpower/hybrid/ext-fields/UUIDs).
test/test_printing.jl	Re-enables printing tests and adds detached-component REPL display regression coverage.
test/test_internal.jl	Re-enables internal UUID validation test.
test/test_hybrid_system.jl	Re-enables HybridSystem parsing/unattached-subcomponent test coverage.
test/test_busnumberchecks.jl	Re-enables matpower bus index/uniqueness validation tests.
test/test_branchchecks_testing.jl	Adds regression tests for negative ratings and voltage-limit selection in line rating calculation.
test/test_base_power.jl	Updates base-power tests and adds extensive transformer (2W/3W) unit conversion/setter round-trip tests.
test/Project.toml	Adds parser packages (currently under `[extras]`).
test/common.jl	Switches tests to use `Unitful.ustrip` directly.
src/utils/print.jl	Makes accessor printing more robust for detached components by falling back to DU when NU fails.
src/utils/IO/branchdata_checks.jl	Fixes `line_rating_calculation` to use the to-side Vmin; improves negative-rate logging; adds negative transformer rate guard.
src/units/types.jl	Updates `UnitArg` to `IS.AbstractUnitSystem` and adds `Unitful.ustrip` support for `IS.RelativeQuantity`.
src/units/serialization.jl	Removes unused `StructTypes` import; fixes RelativeQuantity unit serialization to derive unit from type parameter.
src/units/conversions.jl	Adds base-voltage checks; simplifies DU↔SU relative conversions via `_du_to_su_ratio`; removes bespoke multi-winding conversion family in favor of per-winding base providers.
src/PowerSystems.jl	Exports new `supports_*` helpers; removes exported `ustrip`; updates imports (adds `get_value`/`set_value`, uses `Unitful.ustrip`).
src/models/supplemental_accessors.jl	Refines “rounder” voltage selection logic; adds `supports_active_power`/`supports_reactive_power`/`supports_voltage_control` overrides for several device types.
src/models/static_models.jl	Introduces base `supports_active_power` / `supports_reactive_power` / `supports_voltage_control` defaults for `StaticInjection`.
src/models/generated/VariableReserveNonSpinning.jl	Updates `get_requirement` docs and `display_units_arg` formatting for explicit-units accessors.
src/models/generated/VariableReserve.jl	Makes `requirement` unit-aware via `get_value`/`set_value`; updates docs to specify SYSTEM_BASE p.u.
src/models/generated/TwoTerminalLCCLine.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/TwoTerminalGenericHVDCLine.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/TransmissionInterface.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/Transformer2W.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/TModelHVDCLine.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ThermalStandard.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ThermalMultiStart.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/TapTransformer.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/SynchronousCondenser.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/Source.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ShiftablePowerLoad.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/RenewableNonDispatch.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/RenewableDispatch.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/PowerLoad.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/PhaseShiftingTransformer.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/MotorLoad.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/LoadZone.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/Line.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/InterruptiblePowerLoad.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/InterconnectingConverter.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/HydroTurbine.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/HydroDispatch.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/GenericArcImpedance.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ExponentialLoad.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/EnergyReservoirStorage.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/DiscreteControlledACBranch.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ConstantReserveNonSpinning.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/ConstantReserveGroup.jl	Updates unit-aware accessor docstrings and `display_units_arg` signatures for parametric type.
src/models/generated/ConstantReserve.jl	Updates unit-aware accessor docstrings and `display_units_arg` signatures for parametric type.
src/models/generated/AreaInterchange.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/generated/Area.jl	Updates unit-aware accessor docstrings and `display_units_arg` formatting.
src/models/cost_functions/ImportExportCost.jl	Updates constructor to use kwarg path for Nothing-handling; handles `nothing` offsets in curve validation.
src/emissions_data.jl	Fixes doc reference to supplemental attributes documentation anchor.
src/descriptors/power_system_structs.json	Marks `VariableReserve.requirement` as needing conversion (`:mva`) and clarifies doc comment.
src/definitions.jl	Adds `ZERO_ADMITTANCE_THRESHOLD` for admittance capability detection.
src/base.jl	Updates unit-base docs to emphasize metadata-only behavior under explicit-unit accessors.
README.md	Updates documentation badge link to published docs site.
Project.toml	Removes unused `StructTypes` dependency and compat constraint.
docs/src/explanation/per_unit.md	Updates per-unit documentation for explicit-units (PSY6) programming model and migration guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

+[extras]
+PowerFlowFileParser = "bed98974-b02e-5e2f-9ee0-a103f5c450dd"
+PowerTableDataParser = "2b750c0e-0bff-11f1-9200-1befd75df6be"
+
 [sources]


luke-kiernan

I like the simplifications. I did some pretty thorough performance optimization stuff on the old version, though. So requests:

Verify that the internal conversions get compiled away: code_lowered on get_active_power(g, {SU/DU/NU}) should show getfield plus straight float arithmetic.
Verify that ustrip is a no-op when types are inferred: ustrip(get_active_power_unitful(g, {SU/DU/NU})) compiles to the same thing as the non-unitful getter.
Performance check: should get similar results to here
Type stability audit.

…son-pqzkyz

Copilot

Pull request overview

Copilot reviewed 36 out of 78 changed files in this pull request and generated 1 comment.

+[extras]
+PowerFlowFileParser = "bed98974-b02e-5e2f-9ee0-a103f5c450dd"
+PowerTableDataParser = "2b750c0e-0bff-11f1-9200-1befd75df6be"
+


…nits Remove extra and

Copilot AI and others added 26 commits March 24, 2026 20:10

Initial plan

1811203

Make FACTS and SynchronousCondenser traits instance-based, checking c…

2fc6c08

…ontrol_mode and bus type Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/65d79b71-2f1c-4c06-b213-6b72d532bed5

Extract shared FACTS control_mode check into helper, add clarifying c…

72065ed

…omment Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/65d79b71-2f1c-4c06-b213-6b72d532bed5

Make supports_active_power instance-based for FACTSControlDevice (tru…

18b43f6

…e for NML mode) Co-authored-by: m-bossart <67015312+m-bossart@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/4e8ef608-6efd-4060-b37e-d9bbcfceef46

Allow SwitchedAdmittance to support reactive power (remove false over…

d1d6190

…ride) Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/48a5642f-e0b8-4fac-b6fa-a26153919ad0

Simplify SynchronousCondenser voltage control check to bustype only (…

09b672a

…bus is never nothing) Co-authored-by: jd-lara <16385323+jd-lara@users.noreply.github.com> Agent-Logs-Url: https://github.com/NREL-Sienna/PowerSystems.jl/sessions/514ef393-9a13-4754-bbd1-ccff32acb69b

Merge remote-tracking branch 'origin/main' into copilot/add-traits-to…

0256834

…-static-injectors

Fix docs badge link

7e32f55

Initial plan

c10d160

Merge pull request #1686 from Sienna-Platform/kd/badge

84727a4

Minor Fix: docs badge link

add missing traits

9dc0d1a

fix: resolve broken SupplementalAttribute docs reference

6d9b8da

Merge branch 'main' into copilot/fix-github-actions-build-job

c847a1c

Merge pull request #1688 from Sienna-Platform/copilot/fix-github-acti…

3b62f66

…ons-build-job Fix broken SupplementalAttribute docs cross-reference

fix branch check bug

f60bec2

Merge pull request #1645 from Sienna-Platform/copilot/add-traits-to-s…

0346bf4

…tatic-injectors Add traits to static injectors about active power, reactive power, voltage control

Merge remote-tracking branch 'origin/main' into claude/inspiring-john…

e496f58

…son-pqzkyz # Conflicts: # test/test_devices.jl

regenerate the structs

a8af3d0

update per unit docs

e462a85

update deps

a3cba83

update the structs

8a6089c

update the units handling

ea90a4f

update tests deps

4a1ccba

update tests

ab2662c

jd-lara requested a review from Copilot June 10, 2026 22:15

Copilot started reviewing on behalf of jd-lara June 10, 2026 22:15 View session

jd-lara requested review from kdayday and removed request for kdayday June 10, 2026 22:15

jd-lara requested a review from luke-kiernan June 10, 2026 22:15

Copilot AI reviewed Jun 10, 2026

View reviewed changes

Comment thread test/Project.toml

Comment on lines 20 to 26

Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

[extras]

PowerFlowFileParser = "bed98974-b02e-5e2f-9ee0-a103f5c450dd"

PowerTableDataParser = "2b750c0e-0bff-11f1-9200-1befd75df6be"

[sources]

luke-kiernan approved these changes Jun 11, 2026

View reviewed changes

Merge remote-tracking branch 'origin/psy6' into claude/inspiring-john…

37aa913

…son-pqzkyz

jd-lara requested a review from Copilot June 11, 2026 17:18

Copilot started reviewing on behalf of jd-lara June 11, 2026 17:18 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread test/Project.toml Outdated

Comment on lines +22 to +25

[extras]

PowerFlowFileParser = "bed98974-b02e-5e2f-9ee0-a103f5c450dd"

PowerTableDataParser = "2b750c0e-0bff-11f1-9200-1befd75df6be"

jd-lara and others added 5 commits June 11, 2026 12:08

fix docs

3fc219f

claude added an extra end...

0155c49

Merge pull request #1696 from Sienna-Platform/ac/hybridsystem-strip-u…

3e7a96b

…nits Remove extra and

fix docs deps

0f98a96

add missing tests Luke asked for

0e3deb1

jd-lara merged commit e2dad20 into psy6 Jun 11, 2026
1 of 9 checks passed

jd-lara deleted the claude/inspiring-johnson-pqzkyz branch June 11, 2026 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Claude/inspiring johnson pqzkyz#1695

Claude/inspiring johnson pqzkyz#1695
jd-lara merged 32 commits into
psy6from
claude/inspiring-johnson-pqzkyz

jd-lara commented Jun 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

luke-kiernan left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jd-lara commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

luke-kiernan left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jd-lara commented Jun 10, 2026 •

edited

Loading