Clear bus_hvdc_net_power in clear_injection_data!#395
Closed
luke-kiernan wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Performance ResultsPrecompile Time
Solve TimePolar AC
Rectangular CI
Mixed CPB
DC
|
Member
|
unconditionally zeroing it inside clear_injection_data! introduces a silent regression in the DC PF, so I'm proposing we close this in favor of handling the reset on the PowerSimulations side in Sienna-Platform/PowerSimulations.jl#1637 I tested the fix on the Argentina system too and corrected the issues found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero
bus_hvdc_net_powereach solve, alongside the other injection fields, so construction-time native HVDC setpoints don't double-count and per-solve writes don't accumulate.🤖 Generated with Claude Code