filter aux vars#74
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR narrows the auxiliary-variable keys used by get_load_data to only load-relevant entries, preventing failures when unrelated aux variables (e.g., power-flow related) are present in the results.
Changes:
- Added
get_load_aux_variable_keysto filter aux-variable keys toPSY.ElectricLoad+PSI.PowerOutput. - Updated
get_load_data(results::IS.Results, ...)to apply the new aux-variable filtering before reading aux-variable results.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
410
to
414
| variable_keys = get_load_variable_keys(results; variable_keys = variable_keys) | ||
| parameter_keys = get_load_parameter_keys(results; parameter_keys = parameter_keys) | ||
| aux_variable_keys = | ||
| get_load_aux_variable_keys(results; aux_variable_keys = aux_variable_keys) | ||
|
|
Comment on lines
+111
to
+124
| function get_load_aux_variable_keys( | ||
| results::IS.Results; | ||
| aux_variable_keys::Vector{T} = PSI.list_aux_variable_keys(results), | ||
| ) where {T <: PSI.OptimizationContainerKey} | ||
| # TODO: add slacks | ||
| filter_keys = Vector{PSI.OptimizationContainerKey}() | ||
| for k in aux_variable_keys | ||
| if PSI.get_component_type(k) <: PSY.ElectricLoad && | ||
| PSI.get_entry_type(k) == PSI.PowerOutput | ||
| push!(filter_keys, k) | ||
| end | ||
| end | ||
| return filter_keys | ||
| end |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 88.79% 88.55% -0.25%
==========================================
Files 7 7
Lines 723 734 +11
==========================================
+ Hits 642 650 +8
- Misses 81 84 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jd-lara
reviewed
May 28, 2026
| aux_variable_keys::Vector{T} = PSI.list_aux_variable_keys(results), | ||
| ) where {T <: PSI.OptimizationContainerKey} | ||
| # TODO: add slacks | ||
| filter_keys = Vector{PSI.OptimizationContainerKey}() |
Member
There was a problem hiding this comment.
I don't understand why you are just capturing the load AuxVars
jd-lara
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter to only relevant aux variables in
get_load_data. Avoids failures in processing power flow aux variables.