Skip to content

fix default genrator mapping file#66

Closed
m-bossart wants to merge 4 commits into
mainfrom
mb/default-generator-mapping
Closed

fix default genrator mapping file#66
m-bossart wants to merge 4 commits into
mainfrom
mb/default-generator-mapping

Conversation

@m-bossart

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the default generator-to-category mapping used by PowerAnalytics to classify natural-gas generators into the intended categories.

Changes:

  • Adjust NG-CT mapping to use prime mover GT for NATURAL_GAS.
  • Expand NG-CC mapping to include additional prime movers (CA, CT) for NATURAL_GAS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@m-bossart

Copy link
Copy Markdown
Contributor Author

@copilot Open a PR which fixes the expected test values so the tests pass. The value changes are expected given the change of generator mappings.

Copilot AI commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

@m-bossart I've opened a new pull request, #67, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits April 15, 2026 04:16
Fix test expected values after generator mapping update
@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.04%. Comparing base (a48ce53) to head (35b9fe3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files           7        7           
  Lines         669      669           
=======================================
  Hits          589      589           
  Misses         80       80           
Flag Coverage Δ
unittests 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jd-lara

jd-lara commented May 18, 2026

Copy link
Copy Markdown
Member

closed in favor of #72

@jd-lara jd-lara closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants