Skip to content

refractor(core): centralize normalize_windows_path utility#35

Merged
Sid-352 merged 2 commits into
Sid-352:mainfrom
dharapandya85:refractor/centralize-path-normalizer
May 24, 2026
Merged

refractor(core): centralize normalize_windows_path utility#35
Sid-352 merged 2 commits into
Sid-352:mainfrom
dharapandya85:refractor/centralize-path-normalizer

Conversation

@dharapandya85
Copy link
Copy Markdown
Contributor

Description

Briefly explain what this PR does and why it is necessary.
This PR removes duplicated normalize_windows_path implementation from arbitar-forge/src/main.rs and maintains it in arbiter-core/src/lib.rs.

Related Issue

Closes #29 [Insert Issue Number]

Checklist

  • I have read the CONTRIBUTING.md guidelines.
  • [x ] My code passes cargo clippy -- -D warnings and cargo fmt.
  • I have included rationale-only comments for complex logic.
  • I have added or updated unit tests (if applicable).

AI-Generated Code Compliance

  • This PR contains code generated or assisted by an LLM.
  • I have manually reviewed, tested, and verified every line of this code. Any issues faced, created or caused by the code are my own fault.
  • I can fully explain the low-level mechanics of this implementation and guarantee it does not introduce memory leaks, race conditions, or undefined behavior.

Copy link
Copy Markdown
Owner

@Sid-352 Sid-352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dharapandya85 Code itself is decent, works well and centralized. However, there are two quick things to fix before we can merge:

  • Failing Test: In removes_trailing_slash, the assertion checks for r"C\:temp\folder" instead of r"C:\temp\folder". Please fix the typo and verify that cargo test actually passes locally.
  • Dead Code: Completely delete the commented-out function block in arbiter-forge/src/main.rs. We don't need to leave commented code behind.

Push those fixes and I'll get this merged.

@Sid-352 Sid-352 merged commit 289e1c6 into Sid-352:main May 24, 2026
1 check passed
@Sid-352 Sid-352 added nsoc26 Label for Nexus Spring of Code contributors level1 Simple addition, bugfix or change labels May 24, 2026
@Sid-352
Copy link
Copy Markdown
Owner

Sid-352 commented May 24, 2026

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level1 Simple addition, bugfix or change nsoc26 Label for Nexus Spring of Code contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NSoC] Standardize Windows Path Normalization

2 participants