refractor(core): centralize normalize_windows_path utility#35
Merged
Sid-352 merged 2 commits intoMay 24, 2026
Merged
Conversation
Sid-352
approved these changes
May 24, 2026
Owner
There was a problem hiding this comment.
@dharapandya85 Code itself is decent, works well and centralized. However, there are two quick things to fix before we can merge:
- Failing Test: In removes_trailing_slash, the assertion checks for
r"C\:temp\folder"instead ofr"C:\temp\folder". Please fix the typo and verify that cargo test actually passes locally. - Dead Code: Completely delete the commented-out function block in arbiter-forge/src/main.rs. We don't need to leave commented code behind.
Push those fixes and I'll get this merged.
Owner
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly explain what this PR does and why it is necessary.
This PR removes duplicated
normalize_windows_pathimplementation fromarbitar-forge/src/main.rsand maintains it inarbiter-core/src/lib.rs.Related Issue
Closes #29 [Insert Issue Number]
Checklist
CONTRIBUTING.mdguidelines.cargo clippy -- -D warningsandcargo fmt.AI-Generated Code Compliance