2025 10 13 patch generic array

.github/workflows/clippy-lint.yaml

@@ -24,7 +24,7 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: stable
+          toolchain: 1.89
           override: true
           components: clippy
       - name: Run Clippy on different workspaces and crates

.github/workflows/coverage-protocols.yaml

@@ -1,7 +1,7 @@
 name: Protocol test Coverage
 
 on:
-  pull_request:
+  push:
     branches:
       - main
 
@@ -53,6 +53,14 @@ jobs:
           flags: codec_sv2-coverage
           token: ${{ secrets.CODECOV_TOKEN }}
 
+      - name: Upload channels_sv2-coverage to codecov.io
+        uses: codecov/codecov-action@v4
+        with:
+          directory: ./protocols/target/tarpaulin-reports/channels-sv2-coverage
+          file: ./protocols/target/tarpaulin-reports/channels-sv2-coverage/cobertura.xml
+          flags: channels_sv2-coverage
+          token: ${{ secrets.CODECOV_TOKEN }}
+
       - name: Upload common_messages_sv2-coverage to codecov.io
         uses: codecov/codecov-action@v4
         with:
@@ -85,6 +93,14 @@ jobs:
           flags: noise_sv2-coverage
           token: ${{ secrets.CODECOV_TOKEN }}
 
+      - name: Upload parsers_sv2-coverage to codecov.io
+        uses: codecov/codecov-action@v4
+        with:
+          directory: ./protocols/target/tarpaulin-reports/parsers-sv2-coverage
+          file: ./protocols/target/tarpaulin-reports/parsers-sv2-coverage/cobertura.xml
+          flags: parsers_sv2-coverage
+          token: ${{ secrets.CODECOV_TOKEN }}
+
       - name: Upload roles_logic_sv2-coverage to codecov.io
         uses: codecov/codecov-action@v4
         with:
@@ -101,14 +117,6 @@ jobs:
           flags: v1-coverage
           token: ${{ secrets.CODECOV_TOKEN }}
 
-      - name: Upload sv2_ffi-coverage to codecov.io
-        uses: codecov/codecov-action@v4
-        with:
-          directory: ./protocols/target/tarpaulin-reports/sv2-ffi-coverage
-          file: ./protocols/target/tarpaulin-reports/sv2-ffi-coverage/cobertura.xml
-          flags: sv2_ffi-coverage
-          token: ${{ secrets.CODECOV_TOKEN }}
-
       - name: Upload template_distribution_sv2-coverage to codecov.io
         uses: codecov/codecov-action@v4
         with:

.github/workflows/coverage-roles.yaml

@@ -1,7 +1,7 @@
 name: Roles test Coverage
 
 on:
-  pull_request:
+  push:
     branches:
       - main
 
@@ -53,14 +53,6 @@ jobs:
           flags: mining_device-coverage
           token: ${{ secrets.CODECOV_TOKEN }}
 
-      - name: Upload mining_proxy_sv2-coverage to codecov.io
-        uses: codecov/codecov-action@v4
-        with:
-          directory: ./roles/target/tarpaulin-reports/mining-proxy-coverage
-          file: ./roles/target/tarpaulin-reports/mining-proxy-coverage/cobertura.xml
-          flags: mining_proxy_sv2-coverage
-          token: ${{ secrets.CODECOV_TOKEN }}
-
       - name: Upload pool_sv2-coverage to codecov.io
         uses: codecov/codecov-action@v4
         with:

.github/workflows/coverage-utils.yaml

@@ -1,7 +1,7 @@
 name: Util Test Coverage
 
 on:
-  pull_request:
+  push:
     branches:
       - main
 

.github/workflows/docs.yaml

@@ -49,6 +49,16 @@ jobs:
           cd protocols/v2/binary-sv2
           cargo doc --features with_buffer_pool
 
+      - name: Rust Docs crate channels_sv2
+        run: |
+          cd protocols/v2/channels-sv2
+          cargo doc
+
+      - name: Rust Docs crate parsers_sv2
+        run: |
+          cd protocols/v2/parsers-sv2
+          cargo doc
+
       - name: Rust Docs crate framing_sv2
         run: |
           cd protocols/v2/framing-sv2
@@ -84,11 +94,6 @@ jobs:
           cd protocols/v2/subprotocols/template-distribution
           cargo doc
 
-      - name: Rust Docs crate sv2_ffi
-        run: |
-          cd protocols/v2/sv2-ffi
-          cargo doc
-
       - name: Rust Docs crate roles_logic_sv2
 
         run: |

.github/workflows/integration-tests.yaml

@@ -24,10 +24,9 @@ jobs:
           toolchain: stable
           override: true
 
-      - name: Roles Integration Tests
-        run: |
-         RUST_BACKTRACE=1 RUST_LOG=debug cargo test --manifest-path=test/integration-tests/Cargo.toml --verbose --test '*' -- --nocapture
+      - name: Install cargo-nextest
+        run: cargo install cargo-nextest --locked
 
-      - name: SV1 Integration Tests
+      - name: Integration Tests
         run: |
-         RUST_BACKTRACE=1 RUST_LOG=debug cargo test --manifest-path=test/integration-tests/Cargo.toml --verbose --test 'sv1' --features sv1 -- --nocapture
+         RUST_BACKTRACE=1 RUST_LOG=debug cargo nextest run --manifest-path=test/integration-tests/Cargo.toml --features sv1 --nocapture

.github/workflows/release-libs.yaml

@@ -29,38 +29,51 @@ jobs:
       - name: Login
         run: cargo login ${{ secrets.CRATES_IO_DEPLOY_KEY }}
 
-      - name: Publish crate common
+      # Base dependencies with no local dependencies
+      - name: Publish crate config_helpers_sv2
         run: |
-          ./scripts/release-libs.sh common
-
+          ./scripts/release-libs.sh roles/roles-utils/config-helpers
+          
       - name: Publish crate buffer_sv2
         run: |
           ./scripts/release-libs.sh utils/buffer
 
-      - name: Publish crate binary_sv2 derive_codec
+      - name: Publish crate error-handling
         run: |
-          ./scripts/release-libs.sh protocols/v2/binary-sv2/derive_codec
+          ./scripts/release-libs.sh utils/error-handling
+
+      - name: Publish crate key-utils
+        run: |
+          ./scripts/release-libs.sh utils/key-utils
 
+      - name: Publish crate noise_sv2
+        run: |
+          ./scripts/release-libs.sh protocols/v2/noise-sv2
+
+      # binary_sv2 (depends on buffer_sv2)
       - name: Publish crate binary_sv2 codec
         run: |
           ./scripts/release-libs.sh protocols/v2/binary-sv2/codec
 
+      - name: Publish crate binary_sv2 derive_codec
+        run: |
+          ./scripts/release-libs.sh protocols/v2/binary-sv2/derive_codec
+
       - name: Publish crate binary_sv2
         run: |
           ./scripts/release-libs.sh protocols/v2/binary-sv2
 
+      # framing_sv2(depends on binary_sv2, buffer_sv2, noise_sv2)
       - name: Publish crate framing_sv2
         run: |
           ./scripts/release-libs.sh protocols/v2/framing-sv2
 
-      - name: Publish crate noise_sv2
-        run: |
-          ./scripts/release-libs.sh protocols/v2/noise-sv2
-
+      # codec_sv2 (depends on framing_sv2, noise_sv2, binary_sv2, buffer_sv2, key-utils)
       - name: Publish crate codec_sv2
         run: |
           ./scripts/release-libs.sh protocols/v2/codec-sv2
 
+      # Subprotocols (depend on binary_sv2)
       - name: Publish crate common_messages
         run: |
           ./scripts/release-libs.sh protocols/v2/subprotocols/common-messages
@@ -77,34 +90,51 @@ jobs:
         run: |
           ./scripts/release-libs.sh protocols/v2/subprotocols/template-distribution
 
-      - name: Publish crate sv2_ffi
+      # channels_sv2 (depends on binary_sv2, common_messages_sv2, mining_sv2, template_distribution_sv2, job_declaration_sv2)
+      - name: Publish crate channels_sv2
         run: |
-          ./scripts/release-libs.sh protocols/v2/sv2-ffi
+          ./scripts/release-libs.sh protocols/v2/channels-sv2
 
-      - name: Publish crate roles_logic_sv2
+      # parsers_sv2 (depends on binary_sv2, framing_sv2, common_messages, mining, template_distribution, job_declaration)
+      - name: Publish crate parsers_sv2
         run: |
-          ./scripts/release-libs.sh protocols/v2/roles-logic-sv2
+          ./scripts/release-libs.sh protocols/v2/parsers-sv2
 
+      # sv1_api (depends on binary_sv2)
       - name: Publish crate v1
         run: |
           ./scripts/release-libs.sh protocols/v1
 
-      - name: Publish crate bip32-key-derivation
+      # stratum_translation (depends on binary_sv2, mining_sv2, channels_sv2, v1)
+      - name: Publish crate stratum_translation
         run: |
-          ./scripts/release-libs.sh utils/bip32-key-derivation
+          ./scripts/release-libs.sh roles/roles-utils/stratum-translation
 
-      - name: Publish crate error-handling
-        run: |
-          ./scripts/release-libs.sh utils/error-handling
-
-      - name: Publish crate key-utils
+      # Roles logic (depends on codec_sv2 and subprotocols)
+      - name: Publish crate roles_logic_sv2
         run: |
-          ./scripts/release-libs.sh utils/key-utils
+          ./scripts/release-libs.sh protocols/v2/roles-logic-sv2
 
+      # Network helpers (depends on codec_sv2, sv1_api)
       - name: Publish crate network_helpers_sv2
         run: |
           ./scripts/release-libs.sh roles/roles-utils/network-helpers
 
+      # Common (depends on roles_logic_sv2 and network_helpers_sv2)
+      - name: Publish crate common
+        run: |
+          ./scripts/release-libs.sh common
+
+      # handlers_sv2 (depends on parsers_sv2, binary_sv2, common_messages_sv2, mining_sv2, template_distribution_sv2, job_declaration_sv2)
+      - name: Publish crate handlers_sv2
+        run: |
+          ./scripts/release-libs.sh protocols/v2/handlers-sv2
+
+      # Utilities that depend on stratum-common
+      - name: Publish crate bip32-key-derivation
+        run: |
+          ./scripts/release-libs.sh utils/bip32-key-derivation
+
       - name: Publish crate rpc_sv2
         run: |
-          ./scripts/release-libs.sh roles/roles-utils/rpc
+          ./scripts/release-libs.sh roles/roles-utils/rpc

.github/workflows/rust-msrv.yaml

@@ -27,20 +27,20 @@ jobs:
       - name: Build Protocols
         run: cargo build --manifest-path=protocols/Cargo.toml
       - name: Build Roles
-        run: cargo build --manifest-path=roles/Cargo.toml
+        run: cargo build --locked --manifest-path=roles/Cargo.toml
       - name: Build Utils
-        run: cargo build --manifest-path=utils/Cargo.toml
+        run: cargo build --locked --manifest-path=utils/Cargo.toml
       - name: Build Integration Tests
-        run: cargo build --manifest-path=test/integration-tests/Cargo.toml
-      
+        run: cargo build --locked --manifest-path=test/integration-tests/Cargo.toml
+
       # also check test compilation without running tests
       - name: Check Test Compilation for Benches
         run: cargo test --manifest-path=benches/Cargo.toml --no-run
       - name: Check Test Compilation for Protocols
         run: cargo test --manifest-path=protocols/Cargo.toml --no-run
       - name: Check Test Compilation for Roles
-        run: cargo test --manifest-path=roles/Cargo.toml --no-run
+        run: cargo test --locked --manifest-path=roles/Cargo.toml --no-run
       - name: Check Test Compilation for Utils
-        run: cargo test --manifest-path=utils/Cargo.toml --no-run
+        run: cargo test --locked --manifest-path=utils/Cargo.toml --no-run
       - name: Check Test Compilation for Integration Tests
-        run: cargo test --manifest-path=test/integration-tests/Cargo.toml --no-run
+        run: cargo test --locked --manifest-path=test/integration-tests/Cargo.toml --no-run

.github/workflows/semver-check.yaml

@@ -85,14 +85,22 @@ jobs:
         working-directory: protocols/v2/subprotocols/template-distribution
         run: cargo semver-checks
 
-      - name: Run semver checks for protocols/v2/sv2-ffi
-        working-directory: protocols/v2/sv2-ffi
-        run: cargo semver-checks
-
       - name: Run semver checks for protocols/v2/roles-logic-sv2
         working-directory: protocols/v2/roles-logic-sv2
         run: cargo semver-checks --default-features
 
+      - name: Run semver checks for protocols/v2/channels-sv2
+        working-directory: protocols/v2/channels-sv2
+        run: cargo semver-checks
+
+      - name: Run semver checks for protocols/v2/parsers-sv2
+        working-directory: protocols/v2/parsers-sv2
+        run: cargo semver-checks
+
+      - name: Run semver checks for protocols/v2/handlers-sv2
+        working-directory: protocols/v2/handlers-sv2
+        run: cargo semver-checks
+
       - name: Run semver checks for protocols/v1
         working-directory: protocols/v1
         run: cargo semver-checks
@@ -109,10 +117,19 @@ jobs:
         working-directory: utils/key-utils
         run: cargo semver-checks
 
+      # TODO: Uncomment this when the stratum-translation crate is published to crates.io
+      #- name: Run semver checks for roles/roles-utils/stratum-translation
+      #  working-directory: roles/roles-utils/stratum-translation
+      #  run: cargo semver-checks
+
       - name: Run semver checks for roles/roles-utils/network-helpers
         working-directory: roles/roles-utils/network-helpers
         run: cargo semver-checks
 
       - name: Run semver checks for roles/roles-utils/rpc
         working-directory: roles/roles-utils/rpc
         run: cargo semver-checks
+
+      - name: Run semver checks for roles/roles-utils/config-helpers
+        working-directory: roles/roles-utils/config-helpers
+        run: cargo semver-checks

.github/workflows/test.yaml

@@ -11,11 +11,11 @@ jobs:
     strategy:
       matrix:
         os:
-          - macos-13
+          - macos-latest
           - ubuntu-latest
         include:
-          - os: macos-13
-            target: x86_64-apple-darwin
+          - os: macos-latest
+            target: aarch64-apple-darwin
           - os: ubuntu-latest
             target: x86_64-unknown-linux-musl
 
@@ -44,6 +44,19 @@ jobs:
         run: |
           cargo run --manifest-path=protocols/v2/framing-sv2/Cargo.toml --example sv2_frame
 
+      - name: Run codec-sv2 examples
+        run: |
+          cargo run --manifest-path=protocols/v2/codec-sv2/Cargo.toml --example unencrypted
+          cargo run --manifest-path=protocols/v2/codec-sv2/Cargo.toml --example encrypted --features=noise_sv2
+
+      - name: Run binary-sv2 examples
+        run: |
+          cargo run --manifest-path=protocols/v2/binary-sv2/Cargo.toml --example encode_decode
+
+      - name: Run noise-sv2 examples
+        run: |
+          cargo run --manifest-path=protocols/v2/noise-sv2/Cargo.toml --example handshake
+
       - name: fuzz tests
         run: |
           if [ ${{ matrix.os }} == "ubuntu-latest" ]; then
@@ -62,6 +75,7 @@ jobs:
           cargo test --manifest-path=utils/Cargo.toml
           cargo test --manifest-path=roles/roles-utils/config-helpers/Cargo.toml
           cargo test --manifest-path=roles/roles-utils/network-helpers/Cargo.toml sv1_connection::tests::test_sv1_connection --features sv1
+          cargo test --manifest-path=roles/roles-utils/stratum-translation/Cargo.toml
 
       - name: Property based testing
         run: |