Preserve tick count constraints in SQLite migrations - #1540
Open
salasebas wants to merge 1 commit into
Open
Conversation
salasebas
marked this pull request as ready for review
August 19, 2026 08:00
SQLite drops unstated column options on t.change. Restate default and null on tick_count when converting to bigint, and add a corrective migration for databases that already lost those constraints.
salasebas
force-pushed
the
agent/fix-sqlite-migration-defaults
branch
from
August 25, 2026 16:26
5bdb3f3 to
9a1eb3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the full migration history on a Rails 8.1 SQLite database drops
DEFAULT 0andNOT NULLfrommaintenance_tasks_runs.tick_countwhenthe 2022 migration changes it to
bigint. Runs can then persisttick_count = NULLand render indeterminate progress after succeeding.Preserve the constraints explicitly in the historical migration for new
installations. Add a corrective migration for affected databases that
normalizes existing
NULLvalues to zero and restoresbigint,DEFAULT 0, andNOT NULL. Databases with the expected schema areskipped to avoid an unnecessary SQLite table rebuild.
The corrective migration is intentionally irreversible because the
NULL-to-zero normalization cannot be undone reliably.Testing