fix: refresh recycling when extraData changes - #2495
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Include
extraDatain the recycler data-update trigger so changing it re-evaluates active item types before render.Problem
extraDatais the documented marker for list output that depends on state outsidedata. The recycler only processed updates when thedatareference changed, so anextraData-only render could leave active cells assigned to their previous item-type pool.The regression initializes a real render stack, changes only
extraData, and verifies that the active item is reassigned fromstandardtofeatured. It fails on untouchedmainand passes with the dependency change.Compatibility / observable changes
extraDataidentity changes now perform the same recycler update already used fordatachangesextraDatadoes not add workextraDatainto the callback itselfNo breaking change is intended.
Verification
git diff --checkpassedReviewers’ hat-rack 🎩
extraData-only recycling case and intended update cost.