Skip to content

fix: refresh recycling when extraData changes - #2495

Open
OskarEichler wants to merge 1 commit into
Shopify:mainfrom
OskarEichler:codex/flash-list-extra-data-layout-update
Open

fix: refresh recycling when extraData changes#2495
OskarEichler wants to merge 1 commit into
Shopify:mainfrom
OskarEichler:codex/flash-list-extra-data-layout-update

Conversation

@OskarEichler

Copy link
Copy Markdown

Fix

Include extraData in the recycler data-update trigger so changing it re-evaluates active item types before render.

Problem

extraData is the documented marker for list output that depends on state outside data. The recycler only processed updates when the data reference changed, so an extraData-only render could leave active cells assigned to their previous item-type pool.

The regression initializes a real render stack, changes only extraData, and verifies that the active item is reassigned from standard to featured. It fails on untouched main and passes with the dependency change.

Compatibility / observable changes

No breaking change is intended.

Verification

  • focused regression passes
  • full Jest suite: 15 suites, 188 tests passed
  • library TypeScript check passed
  • changed-file ESLint and git diff --check passed
  • React Doctor: 100/100
  • no dependency, lockfile, native SDK, or Songstats application change

Reviewers’ hat-rack 🎩

  • Verify the extraData-only recycling case and intended update cost.
  • Run the existing test/type/lint commands on a supported environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant