Skip to content

fix(types): isolate fixture build output and accept nullable benchmark refs - #2484

Open
OskarEichler wants to merge 1 commit into
Shopify:mainfrom
OskarEichler:codex/flashlist-fixture-react19-types
Open

fix(types): isolate fixture build output and accept nullable benchmark refs#2484
OskarEichler wants to merge 1 commit into
Shopify:mainfrom
OskarEichler:codex/flashlist-fixture-react19-types

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 28, 2026

Copy link
Copy Markdown

Fixes

Emit fixture build output/build-info into its dist directory rather than next to source and e2e files. Build the library first and resolve fixture React/RN declarations from the fixture so React 18 library declarations do not collide with the React 19 example. Accept ordinary nullable useRef values in benchmark hook signatures. Remove retired v1 Twitter fixture props and the no-longer-needed React-version suppressions so this type-checking change builds independently.

Compatibility / observable changes

No breaking API change. Benchmark ref inputs are broadened to accept null explicitly under React 19. Generated fixture JS/declarations move to dist; source/e2e files no longer get shadowing build products.

Verification

  • Consumer verification: the combined fixes were packaged on the unchanged npm 2.3.2 runtime baseline and checked with React Native 0.87.1 / React 19.2.3. Immutable install, lint, both Android Debug variants, both unsigned iOS Simulator variants, four Metro bundles, 13 web targets and four browser-extension builds pass. All 298 installed non-metadata package files match the reviewed artifact byte-for-byte.
  • Independent patch applied to 435b5141df4960ebbbc0b93264db3f5a4b23fffd: all 187 existing tests (14 suites), library TypeScript build and changed-file ESLint pass.
  • The native fixture TypeScript build also passes independently with its own React 19 dependencies.
  • The combined review workspace passes Android Debug, unsigned iOS Simulator Debug/Release, both production Metro bundles, web production export, Docusaurus/Jekyll builds and all 24 existing iOS Detox tests (10 suites). The contacts comparison was rerun after its final change. These combined-workspace results are not a claim that every device/platform was tested independently for this PR.
  • No checked-in tests, reference screenshots, dependency versions or native SDK versions were changed.

Reviewers’ hat-rack 🎩

  • Check the stated compatibility behavior and reproduce the relevant cases above.
  • Run the existing test/type/lint commands and exercise the affected example or list behavior on your supported device matrix.

Physical-device behavior, Android Detox, assistive-technology conformance and release signing were not verified. No app deployment is part of this PR.

…k refs

Emit fixture build output/build-info into its dist directory rather than next to source and e2e files. Build the library first and resolve fixture React/RN declarations from the fixture so React 18 library declarations do not collide with the React 19 example. Accept ordinary nullable useRef values in benchmark hook signatures. Remove retired v1 Twitter fixture props and the no-longer-needed React-version suppressions so this type-checking change builds independently.
@OskarEichler

Copy link
Copy Markdown
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant