fix(example): make web layouts resize safely and preserve list modes - #2482
Open
OskarEichler wants to merge 1 commit into
Open
fix(example): make web layouts resize safely and preserve list modes#2482OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Replace module-scope window access with reactive window dimensions, remount the layout-options list when orientation changes and make mode buttons select rather than toggle. Bound ComplexMasonry pagination timers and use the exported FlashList in the web grid.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Replace module-scope window access with reactive window dimensions, remount the layout-options list when orientation changes and make mode buttons select rather than toggle. Bound ComplexMasonry pagination timers and use the exported FlashList in the web grid.
Compatibility / observable changes
Example-only changes. Importing these examples without window no longer throws; viewport changes update height. Orientation controls remount as required by FlashList. No library API change.
Verification
435b5141df4960ebbbc0b93264db3f5a4b23fffd: all 187 existing tests (14 suites), library TypeScript build and changed-file ESLint pass.Reviewers’ hat-rack 🎩
Physical-device behavior, Android Detox, assistive-technology conformance and release signing were not verified. No app deployment is part of this PR.