fix(example): cancel stale refreshes and handle empty scroll controls - #2480
Open
OskarEichler wants to merge 1 commit into
Open
fix(example): cancel stale refreshes and handle empty scroll controls#2480OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Lazily generate initial data, keep one owned refresh timer, clear it on reset/clear/unmount, ignore duplicate refreshes and avoid dereferencing an absent scroll-to-item target. Use one column in horizontal web mode.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Lazily generate initial data, keep one owned refresh timer, clear it on reset/clear/unmount, ignore duplicate refreshes and avoid dereferencing an absent scroll-to-item target. Use one column in horizontal web mode.
Compatibility / observable changes
Example-only changes. Clearing/resetting cannot be undone by an old refresh; empty scroll-to-item controls are safe. No library API change.
Verification
435b5141df4960ebbbc0b93264db3f5a4b23fffd: all 187 existing tests (14 suites), library TypeScript build and changed-file ESLint pass.Reviewers’ hat-rack 🎩
Physical-device behavior, Android Detox, assistive-technology conformance and release signing were not verified. No app deployment is part of this PR.