fix(example): preserve section data and forward contact scroller refs - #2479
Open
OskarEichler wants to merge 1 commit into
Open
fix(example): preserve section data and forward contact scroller refs#2479OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Remove only the selected item in its section, use immutable functional updates and collision-free section/item keys, support adding after the last section is removed and cancel duplicate/pending refreshes. Build static contacts lazily before the first render, memoize sticky indices in one pass and pass ScrollView directly so refs reach the native scroller.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Remove only the selected item in its section, use immutable functional updates and collision-free section/item keys, support adding after the last section is removed and cancel duplicate/pending refreshes. Build static contacts lazily before the first render, memoize sticky indices in one pass and pass ScrollView directly so refs reach the native scroller.
Compatibility / observable changes
Example-only changes; no library API change. The section removal operation now matches its label. Contact data is available in the first render rather than after a mount effect.
Verification
435b5141df4960ebbbc0b93264db3f5a4b23fffd: all 187 existing tests (14 suites), library TypeScript build and changed-file ESLint pass.Reviewers’ hat-rack 🎩
Physical-device behavior, Android Detox, assistive-technology conformance and release signing were not verified. No app deployment is part of this PR.