Add env var to allow using Partners API #6671
Conversation
|
/snapit |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -29,6 +29,7 @@ export declare const environmentVariables: {
themeKitAccessDomain: string;
json: string;
neverUsePartnersApi: string;
+ usePartnersApi: string;
skipNetworkLevelRetry: string;
maxRequestTimeForNetworkCalls: string;
};
packages/cli-kit/dist/public/node/environment.d.ts@@ -53,7 +53,7 @@ export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): bool
/**
* If true, the CLI should not use the Partners API.
*
- * @returns True when SHOPIFY_CLI_NEVER_USE_PARTNERS_API is set or SHOPIFY_CLI_1P_DEV is not set.
+ * @returns True when the CLI should not use the Partners API.
*/
export declare function blockPartnersAccess(): boolean;
/**
|
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running just |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3422 tests passing in 1390 suites. Report generated by 🧪jest coverage report action from 33e459b |
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
2 participants
WHY are these changes introduced?
Continuation of #6645
Some internal tests are still using Partners apps that can't be migrated yet (related thread), so we need a way to allow 3P apps to use Partners API
WHAT is this pull request doing?
Adds a new
SHOPIFY_CLI_USE_PARTNERS_APIto unblock itHow to test your changes?
p shopify app init --template none --verbose=> No PartnersSHOPIFY_CLI_USE_PARTNERS_API=1 p shopify app init --template none --verbose=> uses PartnersSHOPIFY_CLI_1P_DEV=1 p shopify app init --template none --verbose=> uses PartnersSHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 SHOPIFY_CLI_1P_DEV=1 p shopify app init --template none --verbose=> No PartnersMeasuring impact
How do we know this change was effective? Please choose one:
Checklist