Skip to content

Conversation

@vividviolet
Copy link
Member

@vividviolet vividviolet commented Nov 20, 2025

WHY are these changes introduced?

Related to https://github.com/shop/issues-admin-extensibility/issues/1325

WHAT is this pull request doing?

Enable uploading static files for UI Extensions

How to test your changes?

Unit tests should be sufficient

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.22% (-0.01% 🔻)
13769/17381
🟡 Branches
73.14% (+0.03% 🔼)
6725/9195
🟡 Functions
79.34% (-0.03% 🔻)
3536/4457
🟡 Lines
79.59% (+0.01% 🔼)
13011/16347
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🔴
... / status.ts
0% 100% 0% 0%
🟢
... / bulk-operation-status.ts
96% 85.71% 100% 100%
🟢
... / download-bulk-operation-results.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
90.91% 80.56% 100% 92.31%
🟢
... / format-bulk-operation-status.ts
100% 100% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
72.73% 62.5% 83.33% 71.88%
🟢
... / watch-bulk-operation.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
100%
86.49% (-0.43% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
12.77% (-0.57% 🔻)
2.78% (-0.16% 🔻)
57.14%
12.77% (-0.57% 🔻)
🟡
... / theme-environment.ts
69.57% (-1.86% 🔻)
50%
55.56% (-3.27% 🔻)
69.57% (-1.86% 🔻)

Test suite run success

3423 tests passing in 1390 suites.

Report generated by 🧪jest coverage report action from 359e45f

@vividviolet vividviolet force-pushed the Enable_uploading_tools_schema_json branch from c23529b to 2385738 Compare November 20, 2025 23:25
@vividviolet vividviolet force-pushed the Enable_uploading_tools_schema_json branch from 2385738 to a17c84a Compare November 25, 2025 20:03
@vividviolet vividviolet marked this pull request as ready for review November 25, 2025 20:05
@vividviolet vividviolet requested a review from a team as a code owner November 25, 2025 20:05
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@vividviolet vividviolet force-pushed the Enable_uploading_tools_schema_json branch 3 times, most recently from 5b334c9 to 7daffc2 Compare November 26, 2025 20:56
@vividviolet vividviolet force-pushed the Enable_uploading_tools_schema_json branch from 7daffc2 to 359e45f Compare November 27, 2025 21:29
@vividviolet vividviolet added this pull request to the merge queue Nov 28, 2025
Merged via the queue into main with commit 1421d07 Nov 28, 2025
25 checks passed
@vividviolet vividviolet deleted the Enable_uploading_tools_schema_json branch November 28, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants