This repository was archived by the owner on Aug 15, 2023. It is now read-only.
Dispatch better error handling #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a generic 'service not found' error for any request with HTTP error code between 400 and 500, added checks for 400, 401, 403 and for all the others in that range, give a generic 'Request error' message. Also, changed the second part of the error checking from a simple string into a dict with more details on the error (with message as string, reason as the given json object, and code as the HTTP code returned, to make it easier to act accordingly to the type of error returned by the API.
- added KeyError, as when it returns an error the repositories key is missing and the TypeError used does not catch that issue. - added test assertions against other error fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a generic 'service not found' error for any request with HTTP
error code between 400 and 500, added checks for 400, 401, 403 and for
all the others in that range, give a generic 'Request error' message.
Also, changed the second part of the error checking from a simple string
into a dict with more details on the error (with message as string, reason
as the given json object, and code as the HTTP code returned, to make it
easier to act accordingly to the type of error returned by the API.
I updated the tests with this change implemented as well.