-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Hide approval files in Solution Explorer #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds an ItemGroup to QRCoderTests.csproj marking files matching **.approved. and **.received. as None and setting DependentUpon to the related .cs filename, affecting build item classification and file nesting without code changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
QRCoderTests/QRCoderTests.csproj (1)
57-61
: UseUpdate
instead ofInclude
to reuse the implicitNone
itemsThese approval artefacts are already pulled in by the SDK’s implicit
None
glob. Re-adding them withInclude
clones each item, whileUpdate
lets you setDependentUpon
on the existing entries without duplication. Switching toUpdate
keeps evaluation cleaner and avoids surprising metadata collisions if more tweaks are applied later.- <ItemGroup> - <None Include="**\*.approved.*;**\*.received.*"> + <ItemGroup> + <None Update="**\*.approved.*;**\*.received.*"> <DependentUpon>$([System.String]::Copy('%(Filename)').Split('.')[0]).cs</DependentUpon> </None> </ItemGroup>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
QRCoderTests/QRCoderTests.csproj
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: additional-tests
@gfoidl Btw, as it pertains to GitHub PRs, I try to mark the milestone for any PR that changes the core project. However, changes to CI, tests, and sometimes documentation, I do not set the milestone, as it is not relevant to anyone trying to see a history of what was changed in a specific version. For issues, I mark the milestone when there is a goal to complete the specific issue within that milestone. I've already updated the issue list, marking most of the issues with either Feel free to add issues and/or mark milestones on any issues you want to have addressed within a specific milestone. |
@Shane32 the outline from the last comment is perfect. |
Nests approval files underneath their corresponding class
Summary by CodeRabbit
Tests
Chores
No user-facing changes or behavioral modifications.