Skip to content

Conversation

Shane32
Copy link
Owner

@Shane32 Shane32 commented Oct 2, 2025

Nests approval files underneath their corresponding class

image

Summary by CodeRabbit

  • Tests

    • Updated test project configuration to exclude verification artifacts from build and associate them with their corresponding test files for better organization in IDEs.
  • Chores

    • Improved handling of non-source test files to reduce clutter and streamline project navigation.

No user-facing changes or behavioral modifications.

@Shane32 Shane32 self-assigned this Oct 2, 2025
Copy link

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Adds an ItemGroup to QRCoderTests.csproj marking files matching **.approved. and **.received. as None and setting DependentUpon to the related .cs filename, affecting build item classification and file nesting without code changes.

Changes

Cohort / File(s) Summary
Test project build item metadata
QRCoderTests/QRCoderTests.csproj
Added ItemGroup to include **\*.approved.* and **\*.received.* as None with DependentUpon set to the base .cs file, altering build/content handling and IDE nesting for approval test artifacts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit's high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change—hiding approval files in Solution Explorer by adjusting project file item settings—and is both clear and specific without extraneous information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hide_approval_files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Shane32 Shane32 requested a review from gfoidl October 2, 2025 20:43
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
QRCoderTests/QRCoderTests.csproj (1)

57-61: Use Update instead of Include to reuse the implicit None items

These approval artefacts are already pulled in by the SDK’s implicit None glob. Re-adding them with Include clones each item, while Update lets you set DependentUpon on the existing entries without duplication. Switching to Update keeps evaluation cleaner and avoids surprising metadata collisions if more tweaks are applied later.

-  <ItemGroup>
-    <None Include="**\*.approved.*;**\*.received.*">
+  <ItemGroup>
+    <None Update="**\*.approved.*;**\*.received.*">
       <DependentUpon>$([System.String]::Copy('%(Filename)').Split('.')[0]).cs</DependentUpon>
     </None>
   </ItemGroup>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 760a6ca and b7d84bd.

📒 Files selected for processing (1)
  • QRCoderTests/QRCoderTests.csproj (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: additional-tests

@Shane32
Copy link
Owner Author

Shane32 commented Oct 2, 2025

@gfoidl Btw, as it pertains to GitHub PRs, I try to mark the milestone for any PR that changes the core project. However, changes to CI, tests, and sometimes documentation, I do not set the milestone, as it is not relevant to anyone trying to see a history of what was changed in a specific version.

For issues, I mark the milestone when there is a goal to complete the specific issue within that milestone. I've already updated the issue list, marking most of the issues with either 1.7.0, 2.0.0 or Future.

Feel free to add issues and/or mark milestones on any issues you want to have addressed within a specific milestone.

@gfoidl
Copy link
Collaborator

gfoidl commented Oct 2, 2025

@Shane32 the outline from the last comment is perfect.
We're quite similar in managing a project.

@Shane32 Shane32 merged commit 434e7be into master Oct 2, 2025
11 checks passed
@Shane32 Shane32 deleted the hide_approval_files branch October 2, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants